Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sources/ScopeChainSidebarPane.js

Issue 2238003002: DevTools: migrate sources panel sidebar to views. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: followed up on the watch test. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008 Apple Inc. All Rights Reserved.
3 * Copyright (C) 2011 Google Inc. All rights reserved. 3 * Copyright (C) 2011 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
11 * notice, this list of conditions and the following disclaimer in the 11 * notice, this list of conditions and the following disclaimer in the
12 * documentation and/or other materials provided with the distribution. 12 * documentation and/or other materials provided with the distribution.
13 * 13 *
14 * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY 14 * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
15 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 15 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
16 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 16 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
17 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR 17 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR
18 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, 18 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
19 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, 19 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
20 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR 20 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
21 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY 21 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
22 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 22 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
23 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 23 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
24 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 24 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
25 */ 25 */
26 26
27 /** 27 /**
28 * @constructor 28 * @constructor
29 * @extends {WebInspector.SimpleView} 29 * @extends {WebInspector.VBox}
30 */ 30 */
31 WebInspector.ScopeChainSidebarPane = function() 31 WebInspector.ScopeChainSidebarPane = function()
32 { 32 {
33 WebInspector.SimpleView.call(this, WebInspector.UIString("Scope")); 33 WebInspector.VBox.call(this);
34 this._expandController = new WebInspector.ObjectPropertiesSectionExpandContr oller(); 34 this._expandController = new WebInspector.ObjectPropertiesSectionExpandContr oller();
35 this._linkifier = new WebInspector.Linkifier(); 35 this._linkifier = new WebInspector.Linkifier();
36 WebInspector.context.addFlavorChangeListener(WebInspector.DebuggerModel.Call Frame, this._update, this); 36 WebInspector.context.addFlavorChangeListener(WebInspector.DebuggerModel.Call Frame, this._update, this);
dgozman 2016/08/15 21:31:03 Should this be a declarative flavor listener?
37 this._update();
37 } 38 }
38 39
39 WebInspector.ScopeChainSidebarPane._pathSymbol = Symbol("path"); 40 WebInspector.ScopeChainSidebarPane._pathSymbol = Symbol("path");
40 41
41 WebInspector.ScopeChainSidebarPane.prototype = { 42 WebInspector.ScopeChainSidebarPane.prototype = {
42 _update: function() 43 _update: function()
43 { 44 {
44 var callFrame = WebInspector.context.flavor(WebInspector.DebuggerModel.C allFrame); 45 var callFrame = WebInspector.context.flavor(WebInspector.DebuggerModel.C allFrame);
45 this._linkifier.reset(); 46 this._linkifier.reset();
46 WebInspector.SourceMapNamesResolver.resolveThisObject(callFrame) 47 WebInspector.SourceMapNamesResolver.resolveThisObject(callFrame)
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
130 section.objectTreeElement().expand(); 131 section.objectTreeElement().expand();
131 132
132 section.element.classList.add("scope-chain-sidebar-pane-section"); 133 section.element.classList.add("scope-chain-sidebar-pane-section");
133 this.element.appendChild(section.element); 134 this.element.appendChild(section.element);
134 } 135 }
135 this._sidebarPaneUpdatedForTest(); 136 this._sidebarPaneUpdatedForTest();
136 }, 137 },
137 138
138 _sidebarPaneUpdatedForTest: function() { }, 139 _sidebarPaneUpdatedForTest: function() { },
139 140
140 __proto__: WebInspector.SimpleView.prototype 141 __proto__: WebInspector.VBox.prototype
141 } 142 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698