DevTools: migrate sources panel sidebar to views.

DevTools: migrate sources panel sidebar to views.

BUG=634145
Committed: https://crrev.com/c88c2032c2afd035c998da61abc0b92e4253803f
Cr-Commit-Position: refs/heads/master@{#412236}

[pfeldman, 2016-08-15 19:30:35]

pfeldman@chromium.org changed reviewers:
+ dgozman@chromium.org

[pfeldman, 2016-08-15 19:31:37]

The CQ bit was checked by pfeldman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-15 19:32:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pfeldman, 2016-08-15 20:22:48]

https://codereview.chromium.org/2238003002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/watch-expressions-panel-switch-expected.txt
(right):

https://codereview.chromium.org/2238003002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/watch-expressions-panel-switch-expected.txt:4:
x: <not available>
I'm fixing this one.

[dgozman, 2016-08-15 21:31:03]

https://codereview.chromium.org/2238003002/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/http/tests/inspector/debugger-test.js
(right):

https://codereview.chromium.org/2238003002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/inspector/debugger-test.js:355:
setTimeout(() => callback.apply(callback,
InspectorTest._pausedScriptArguments));
Let's try to make this better.

https://codereview.chromium.org/2238003002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/watch-expressions-panel-switch.html
(right):

https://codereview.chromium.org/2238003002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/watch-expressions-panel-switch.html:20:
var updateCount = 6;
8

https://codereview.chromium.org/2238003002/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/sources/JavaScriptBreakpointsSidebarPane.js
(right):

https://codereview.chromium.org/2238003002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/JavaScriptBreakpointsSidebarPane.js:151:
var breakpoint = uiLocation ?
WebInspector.breakpointManager.findBreakpointOnLine(uiLocation.uiSourceCode,
uiLocation.lineNumber) : null;
Either this._breakpointManager or WI.breakpointManager everywhere.

https://codereview.chromium.org/2238003002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/JavaScriptBreakpointsSidebarPane.js:173:
WebInspector.Revealer.reveal(uiLocation);
Inline it.

https://codereview.chromium.org/2238003002/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/sources/ScopeChainSidebarPane.js
(right):

https://codereview.chromium.org/2238003002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/ScopeChainSidebarPane.js:36:
WebInspector.context.addFlavorChangeListener(WebInspector.DebuggerModel.CallFrame,
this._update, this);
Should this be a declarative flavor listener?

https://codereview.chromium.org/2238003002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js
(right):

https://codereview.chromium.org/2238003002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js:89: /**
@type {!WebInspector.View} */
(WebInspector.viewManager.view("sources.xhrBreakpoints")).widget();
Should we use sharedInstance(XHRBreakpointsSidebarPane)?

https://codereview.chromium.org/2238003002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js:262: } else
if (!this._paused) {
nit: let's remove {}

https://codereview.chromium.org/2238003002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js:275:
this._splitWidget.showBoth(true);
Do it in the revealLocation callback.

https://codereview.chromium.org/2238003002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js:434:
WebInspector.debuggerWorkspaceBinding.createCallFrameLiveLocation(callFrame.location(),
this._executionLineChanged.bind(this), this._liveLocationPool);
Let's dispose previous one.

https://codereview.chromium.org/2238003002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js
(right):

https://codereview.chromium.org/2238003002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js:247:
var rangeWithContent = new WebInspector.TextRangeWithContent(textSelection,
this._textEditor.copyRange(textSelection));
Let's extract content via callback.

https://codereview.chromium.org/2238003002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js:248:
contextMenu.appendApplicableItems(rangeWithContent);
So, shortcuts don't work anymore?

https://codereview.chromium.org/2238003002/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js
(right):

https://codereview.chromium.org/2238003002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js:225:

style: extra blank line

[pfeldman, 2016-08-16 00:53:06]

ALL DONE!

[dgozman, 2016-08-16 01:05:10]

lgtm

https://codereview.chromium.org/2238003002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js
(right):

https://codereview.chromium.org/2238003002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js:1299: if
(executionContext)
Let's check for context before copying the text?

[pfeldman, 2016-08-16 01:11:47]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2016-08-16 01:12:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 04:32:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 04:32:05]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[pfeldman, 2016-08-16 13:58:06]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2016-08-16 13:58:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 15:02:52]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-16 15:04:12]

Description was changed from

==========
DevTools: migrate sources panel sidebar to views.

BUG=634145
==========

to

==========
DevTools: migrate sources panel sidebar to views.

BUG=634145

Committed: https://crrev.com/c88c2032c2afd035c998da61abc0b92e4253803f
Cr-Commit-Position: refs/heads/master@{#412236}
==========

[commit-bot: I haz the power, 2016-08-16 15:04:14]

Patchset 4 (id:??) landed as
https://crrev.com/c88c2032c2afd035c998da61abc0b92e4253803f
Cr-Commit-Position: refs/heads/master@{#412236}