Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(738)

Issue 2237983004: Merged: Squashed multiple commits. (Closed)

Created:
4 years, 4 months ago by Jakob Kummerow
Modified:
4 years, 4 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com, v8-merges_googlegroups.com, ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@5.3
Target Ref:
refs/pending/branch-heads/5.3
Project:
v8
Visibility:
Public.

Description

Merged: Squashed multiple commits. Merged: [ic] Don't share LoadGlobalIC slots inside typeof and outside typeof. Revision: d634e65 Merged: [ic] Merge LoadGlobalIC_Slow builtins for inside typeof and outside typeof cases. Revision: b558894 BUG=chromium:634467, chromium:634467 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=verwaest@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/426f51890efa76d39a498ce61167225d04326d49

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -92 lines) Patch
M src/builtins.h View 1 chunk +4 lines, -7 lines 0 comments Download
M src/builtins.cc View 1 chunk +2 lines, -13 lines 0 comments Download
M src/ic/ic.h View 1 chunk +1 line, -6 lines 0 comments Download
M src/ic/ic.cc View 1 chunk +48 lines, -0 lines 0 comments Download
M src/runtime/runtime.h View 3 chunks +2 lines, -3 lines 0 comments Download
M src/runtime/runtime-object.cc View 3 chunks +5 lines, -61 lines 0 comments Download
M test/cctest/test-api-interceptors.cc View 2 chunks +16 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Jakob Kummerow
4 years, 4 months ago (2016-08-12 11:56:23 UTC) #1
Jakob Kummerow
NOTE: This script will no longer automatically update include/v8-version.h and create a tag. This is ...
4 years, 4 months ago (2016-08-12 11:56:24 UTC) #2
Toon Verwaest
rubberstamp lgtm
4 years, 4 months ago (2016-08-12 12:19:50 UTC) #3
Jakob Kummerow
4 years, 4 months ago (2016-08-12 12:21:36 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
426f51890efa76d39a498ce61167225d04326d49.

Powered by Google App Engine
This is Rietveld 408576698