Allow updating arc widget bounds in maximize/fullscreen state.

ash/common/wm/window_state.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_COMMON_WM_WINDOW_STATE_H_
 #define ASH_COMMON_WM_WINDOW_STATE_H_
 
 #include <memory>
 
 #include "ash/ash_export.h"
@@ skipping 271 matching lines @@
   // virtual keyboard bounds changes.
   // TODO(oshima): This is hack. Replace this with proper
   // implementation based on EnsureCaretInRect.
   bool ignore_keyboard_bounds_change() const {
     return ignore_keyboard_bounds_change_;
   }
   void set_ignore_keyboard_bounds_change(bool ignore_keyboard_bounds_change) {
     ignore_keyboard_bounds_change_ = ignore_keyboard_bounds_change;
   }
 
+  // True if the window's bounds can be updated using SET_BOUNDS event in
+  // maiximzed/fullscreen mode.
+  void set_allow_set_bounds_in_maximized(bool value) {
+    allow_set_bounds_in_maximized_ = true;

[reveman, 2016/08/11 19:07:25]

"allow_set_bounds_in_maximized_ = value;" ?

[oshima, 2016/08/11 20:58:56]

Oops, thanks for the catch. Done and added test case for this.

+  }
+  bool allow_set_bounds_in_maximized() const {
+    return allow_set_bounds_in_maximized_;
+  }
+
   // Creates and takes ownership of a pointer to DragDetails when resizing is
   // active. This should be done before a resizer gets created.
   void CreateDragDetails(const gfx::Point& point_in_parent,
                          int window_component,
                          aura::client::WindowMoveSource source);
 
   // Deletes and clears a pointer to DragDetails. This should be done when the
   // resizer gets destroyed.
   void DeleteDragDetails();
 
@@ skipping 66 matching lines @@
   bool can_consume_system_keys_;
   std::unique_ptr<DragDetails> drag_details_;
 
   bool unminimize_to_restore_bounds_;
   bool in_immersive_fullscreen_;
   bool ignore_keyboard_bounds_change_ = false;
   bool hide_shelf_when_fullscreen_;
   bool minimum_visibility_;
   bool can_be_dragged_;
   bool cached_always_on_top_;
+  bool allow_set_bounds_in_maximized_ = false;

[reveman, 2016/08/11 19:07:25]

it's a bit confusing that this is false by default. so normal chrome app window
bounds can't be updated?

[oshima, 2016/08/11 20:58:56]

Maximized state means it's always maximized to its maximum size. Setting bounds
results in updating restore bounds in normal case and will be used when
restored. If an app wants to change the bounds, then it should restore first. 

On second thought, I think we should do this only for arc apps because this
behavior is very specific to arc apps (landscape/portrait). I changed to set
this only when application id is set.

 
   // A property to remember the window position which was set before the
   // auto window position manager changed the window bounds, so that it can get
   // restored when only this one window gets shown.
   std::unique_ptr<gfx::Rect> pre_auto_manage_window_bounds_;
 
   base::ObserverList<WindowStateObserver> observer_list_;
 
   // True to ignore a property change event to avoid reentrance in
   // UpdateWindowStateType()
   bool ignore_property_change_;
 
   std::unique_ptr<State> current_state_;
 
   DISALLOW_COPY_AND_ASSIGN(WindowState);
 };
 
 }  // namespace wm
 }  // namespace ash
 
 #endif  // ASH_COMMON_WM_WINDOW_STATE_H_