Allow updating arc widget bounds in maximize/fullscreen state.

components/exo/shell_surface.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/exo/shell_surface.h"
 
 #include "ash/aura/wm_window_aura.h"
 #include "ash/common/shell_window_ids.h"
 #include "ash/common/wm/window_resizer.h"
 #include "ash/common/wm/window_state.h"
@@ skipping 914 matching lines @@
   window->SetName("ExoShellSurface");
   window->AddChild(surface_->window());
   window->SetEventTargeter(base::WrapUnique(new CustomWindowTargeter));
   SetApplicationId(window, &application_id_);
   SetMainSurface(window, surface_);
 
   // Start tracking changes to window bounds and window state.
   window->AddObserver(this);
   ash::wm::WindowState* window_state = ash::wm::GetWindowState(window);
   window_state->AddObserver(this);
+
+  // Absolete positioned shell surfaces may request the bounds that does not
+  // fill the entire work area / display in maximized / fullscreen state.
+  // Allow such clients to update the bounds in these states.
+  if (!initial_bounds_.IsEmpty() && activatable_)
+    window_state->set_allow_set_bounds_in_maximized(true);
+
   // Notify client of initial state if different than normal.
   if (window_state->GetStateType() != ash::wm::WINDOW_STATE_TYPE_NORMAL &&
       !state_changed_callback_.is_null()) {
     state_changed_callback_.Run(ash::wm::WINDOW_STATE_TYPE_NORMAL,
                                 window_state->GetStateType());
   }
 
   // Disable movement if initial bounds were specified.
   widget_->set_movement_disabled(!initial_bounds_.IsEmpty());
   window_state->set_ignore_keyboard_bounds_change(!initial_bounds_.IsEmpty());
@@ skipping 201 matching lines @@
     default:
       NOTREACHED();
       return gfx::Point();
   }
 }
 
 void ShellSurface::UpdateWidgetBounds() {
   DCHECK(widget_);
 
   // Return early if the shell is currently managing the bounds of the widget.
-  if (widget_->IsMaximized() || widget_->IsFullscreen() || IsResizing())
+  if (((widget_->IsMaximized() || widget_->IsFullscreen()) &&

[reveman, 2016/08/12 23:44:40]

please split this into multiple early outs. something like:

if (!initial_bounds_.IsEmpty() &&
window_state->IsMaximizedOrFullscreenOrPinned())
  return;

if (IsResizing())
  return;


you can use allow_set_bounds_in_maximized instead of !initial_bounds_.IsEmpty()
if you like. either is fine as non-arc windows with that should never be
maximized or made fullscren.

[oshima, 2016/08/13 00:45:07]

splitting done. I still think it's better to use allow_set_bound_in_maximzied()
because that's exact condition that bounds have to be updated in these state.

or I can change the line 939 to

if (!initial_bounds.IsEmtpy())
  window_state->set_allow_set_bounds_in_maximized(true);

because popup will never be maximized nor fullscreen.

WDYT?

+       !ash::wm::GetWindowState(widget_->GetNativeWindow())
+            ->allow_set_bounds_in_maximized()) ||
+      IsResizing()) {
     return;
+  }
 
   // Return early if there is pending configure requests.
   if (!pending_configs_.empty() || scoped_configure_)
     return;
 
   gfx::Rect visible_bounds = GetVisibleBounds();
   gfx::Rect new_widget_bounds = visible_bounds;
 
   // Avoid changing widget origin unless initial bounds were specified and
   // widget origin is always relative to it.
@@ skipping 74 matching lines @@
       shadow_overlay_->layer()->Add(shadow->layer());
       window->AddChild(shadow_overlay_);
       shadow_overlay_->Show();
     }
     shadow_overlay_->SetBounds(shadow_bounds);
     shadow->SetContentBounds(gfx::Rect(shadow_bounds.size()));
   }
 }
 
 }  // namespace exo