Issue 2237953002: Fail gracefully when attempting to evaluate against a VM internal class such a Field.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2237953002: Fail gracefully when attempting to evaluate against a VM internal class such a Field. (Closed)

Created:
4 years, 4 months ago by rmacnak

Modified:
4 years, 4 months ago

Reviewers:
cbernaschina

CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fail gracefully when attempting to evaluate against a VM internal class such a Field. We can't evaluate against these classes because they don't have Dart source, belong to a library, etc. Fixes #27052. R=cbernaschina@google.com Committed: https://github.com/dart-lang/sdk/commit/7244b5de0e857f922c842825f69c7c0c17a5102e

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -0 lines)			Patch
	A	runtime/observatory/tests/service/eval_internal_class_test.dart	View	1	1 chunk	+44 lines, -0 lines	0 comments	Download
	M	runtime/vm/object.cc	View		1 chunk	+7 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

rmacnak

4 years, 4 months ago (2016-08-11 22:09:05 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
7244b5de0e857f922c842825f69c7c0c17a5102e (presubmit successful).