Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2237933002: [turbofan] Re-separate logic for LET and CONST in BuildVariableAssignment (Closed)

Created:
4 years, 4 months ago by adamk
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com, neis
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Re-separate logic for LET and CONST in BuildVariableAssignment The structure of this code changed in https://codereview.chromium.org/2201193004, but the structural changes were not essential to that CL's purpose (which was to use Variable::binding_needs_init() consistently to decide whether to hole-check). Now the code should appear as it did before that change, but with the addition of binding_needs_init() checks. R=bmeurer@chromium.org, mstarzinger@chromium.org Committed: https://crrev.com/b028e64b27a5ccbe69b1f4516650b1584ba9abfb Cr-Commit-Position: refs/heads/master@{#38638}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -13 lines) Patch
M src/compiler/ast-graph-builder.cc View 4 chunks +24 lines, -13 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
adamk
4 years, 4 months ago (2016-08-11 17:48:39 UTC) #1
Michael Starzinger
LGTM. Thanks!
4 years, 4 months ago (2016-08-12 11:05:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2237933002/1
4 years, 4 months ago (2016-08-15 17:35:21 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-15 18:07:45 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-15 18:08:17 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b028e64b27a5ccbe69b1f4516650b1584ba9abfb
Cr-Commit-Position: refs/heads/master@{#38638}

Powered by Google App Engine
This is Rietveld 408576698