Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2237913004: Mojo C++ bindings: support generating code shared by different variants. (Closed)

Created:
4 years, 4 months ago by yzshen1
Modified:
4 years, 4 months ago
Reviewers:
jam
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: support generating code shared by different variants. The refacotring work of extracting shared code will be in follow-up CLs. BUG=632061 Committed: https://crrev.com/a4cbffd67354d2c46f1e9517108328a56cc16ad9 Cr-Commit-Position: refs/heads/master@{#411703}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -43 lines) Patch
M mojo/public/tools/bindings/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
A + mojo/public/tools/bindings/generators/cpp_templates/module-shared-internal.h.tmpl View 1 chunk +1 line, -2 lines 0 comments Download
A + mojo/public/tools/bindings/generators/cpp_templates/module-shared.cc.tmpl View 1 chunk +1 line, -2 lines 0 comments Download
A mojo/public/tools/bindings/generators/cpp_templates/module-shared.h.tmpl View 1 chunk +15 lines, -0 lines 0 comments Download
M mojo/public/tools/bindings/generators/mojom_cpp_generator.py View 1 chunk +38 lines, -15 lines 0 comments Download
M mojo/public/tools/bindings/mojom.gni View 3 chunks +73 lines, -22 lines 0 comments Download
M mojo/public/tools/bindings/mojom_bindings_generator.py View 2 chunks +5 lines, -1 line 0 comments Download
M mojo/public/tools/bindings/pylib/mojom/generate/generator.py View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
yzshen1
Hi, John. Would you please take a look? Thanks! This is part of the effort ...
4 years, 4 months ago (2016-08-11 23:17:48 UTC) #4
jam
lgtm
4 years, 4 months ago (2016-08-12 17:48:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2237913004/1
4 years, 4 months ago (2016-08-12 17:50:24 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-12 18:24:17 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 18:26:24 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a4cbffd67354d2c46f1e9517108328a56cc16ad9
Cr-Commit-Position: refs/heads/master@{#411703}

Powered by Google App Engine
This is Rietveld 408576698