Issue 2237913003: Revert of Switching from the old language detector (CLD2) to the new one (CLD3)

Issue 2237913003: Revert of Switching from the old language detector (CLD2) to the new one (CLD3) (Closed)

Created:
4 years, 4 months ago by xidachen

Modified:
4 years, 4 months ago

Reviewers:
Andrew Hayden (chromium.org), Anton Bakalov, brettw

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert of Switching from the old language detector (CLD2) to the new one (CLD3) (patchset #1 id:1 of https://codereview.chromium.org/2243433002/ ) Reason for revert: Causing build failure: https://build.chromium.org/p/chromium/builders/Mac/builds/18465 Error message: # language_identifier_features.cc _GLOBAL__sub_I_language_identifier_features.cc+0x9a # language_identifier_features.cc chrome_lang_id::RegistryMetadata::Register(chrome_lang_id::RegistryMetadata*) # language_identifier_features.cc _ZN14chrome_lang_id17RegisterableClassINS_15FeatureFunctionINS_8SentenceEJEEEE9registry_E # language_identifier_features.cc chrome_lang_id::__ContinuousBagOfNgramsFunction__factory() # language_identifier_features.cc chrome_lang_id::__ContinuousBagOfNgramsFunction__registrar # language_identifier_features.cc chrome_lang_id::__ContinuousBagOfNgramsFunction__registrar+0x10 # language_identifier_features.cc chrome_lang_id::__ContinuousBagOfNgramsFunction__registrar+0x18 # language_identifier_features.cc chrome_lang_id::__ContinuousBagOfNgramsFunction__registrar+0x20 # language_identifier_features.cc chrome_lang_id::__ContinuousBagOfNgramsFunction__registrar+0x28 # language_identifier_features.cc operator new[](unsigned long) # language_identifier_features.cc sqlite3VXPrintf.zOrd+0x1b67aa # language_identifier_features.cc sqlite3VXPrintf.zOrd+0x1b67c3 # language_identifier_features.cc sqlite3VXPrintf.zOrd+0x1b67e1 Original issue's description: > Switching from the old language detector (CLD2) to the new one (CLD3) > > BUG=624904 > > Committed: https://crrev.com/c2d06cc46ee69d6a90e9374c5b25ab4e4eaabe4f > Cr-Commit-Position: refs/heads/master@{#411377} TBR=andrewhayden@chromium.org,brettw@chromium.org,abakalov@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=624904 Committed: https://crrev.com/0987cdcc91f67119283908578bb74ca124af64cb Cr-Commit-Position: refs/heads/master@{#411397}

Patch Set 1 #

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	third_party/cld/BUILD.gn	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

xidachen

Created Revert of Switching from the old language detector (CLD2) to the new one (CLD3)

4 years, 4 months ago (2016-08-11 19:20:09 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2237913003/1

4 years, 4 months ago (2016-08-11 19:20:43 UTC) #3

commit-bot: I haz the power

Description was changed from ========== Revert of Switching from the old language detector (CLD2) to ...

4 years, 4 months ago (2016-08-11 19:21:39 UTC) #4

Message was sent while issue was closed.

Description was changed from

==========
Revert of Switching from the old language detector (CLD2) to the new one (CLD3)
(patchset #1 id:1 of https://codereview.chromium.org/2243433002/ )

Reason for revert:
Causing build failure:
https://build.chromium.org/p/chromium/builders/Mac/builds/18465

Error message:
# language_identifier_features.cc
_GLOBAL__sub_I_language_identifier_features.cc+0x9a
# language_identifier_features.cc
chrome_lang_id::RegistryMetadata::Register(chrome_lang_id::RegistryMetadata*)
# language_identifier_features.cc
_ZN14chrome_lang_id17RegisterableClassINS_15FeatureFunctionINS_8SentenceEJEEEE9registry_E
# language_identifier_features.cc
chrome_lang_id::__ContinuousBagOfNgramsFunction__factory()
# language_identifier_features.cc
chrome_lang_id::__ContinuousBagOfNgramsFunction__registrar
# language_identifier_features.cc
chrome_lang_id::__ContinuousBagOfNgramsFunction__registrar+0x10
# language_identifier_features.cc
chrome_lang_id::__ContinuousBagOfNgramsFunction__registrar+0x18
# language_identifier_features.cc
chrome_lang_id::__ContinuousBagOfNgramsFunction__registrar+0x20
# language_identifier_features.cc
chrome_lang_id::__ContinuousBagOfNgramsFunction__registrar+0x28
# language_identifier_features.cc operator new[](unsigned long)
# language_identifier_features.cc sqlite3VXPrintf.zOrd+0x1b67aa
# language_identifier_features.cc sqlite3VXPrintf.zOrd+0x1b67c3
# language_identifier_features.cc sqlite3VXPrintf.zOrd+0x1b67e1

Original issue's description:
> Switching from the old language detector (CLD2) to the new one (CLD3)
> 
> BUG=624904
> 
> Committed: https://crrev.com/c2d06cc46ee69d6a90e9374c5b25ab4e4eaabe4f
> Cr-Commit-Position: refs/heads/master@{#411377}

TBR=andrewhayden@chromium.org,brettw@chromium.org,abakalov@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=624904
==========

to

==========
Revert of Switching from the old language detector (CLD2) to the new one (CLD3)
(patchset #1 id:1 of https://codereview.chromium.org/2243433002/ )

Reason for revert:
Causing build failure:
https://build.chromium.org/p/chromium/builders/Mac/builds/18465

Error message:
# language_identifier_features.cc
_GLOBAL__sub_I_language_identifier_features.cc+0x9a
# language_identifier_features.cc
chrome_lang_id::RegistryMetadata::Register(chrome_lang_id::RegistryMetadata*)
# language_identifier_features.cc
_ZN14chrome_lang_id17RegisterableClassINS_15FeatureFunctionINS_8SentenceEJEEEE9registry_E
# language_identifier_features.cc
chrome_lang_id::__ContinuousBagOfNgramsFunction__factory()
# language_identifier_features.cc
chrome_lang_id::__ContinuousBagOfNgramsFunction__registrar
# language_identifier_features.cc
chrome_lang_id::__ContinuousBagOfNgramsFunction__registrar+0x10
# language_identifier_features.cc
chrome_lang_id::__ContinuousBagOfNgramsFunction__registrar+0x18
# language_identifier_features.cc
chrome_lang_id::__ContinuousBagOfNgramsFunction__registrar+0x20
# language_identifier_features.cc
chrome_lang_id::__ContinuousBagOfNgramsFunction__registrar+0x28
# language_identifier_features.cc operator new[](unsigned long)
# language_identifier_features.cc sqlite3VXPrintf.zOrd+0x1b67aa
# language_identifier_features.cc sqlite3VXPrintf.zOrd+0x1b67c3
# language_identifier_features.cc sqlite3VXPrintf.zOrd+0x1b67e1

Original issue's description:
> Switching from the old language detector (CLD2) to the new one (CLD3)
> 
> BUG=624904
> 
> Committed: https://crrev.com/c2d06cc46ee69d6a90e9374c5b25ab4e4eaabe4f
> Cr-Commit-Position: refs/heads/master@{#411377}

TBR=andrewhayden@chromium.org,brettw@chromium.org,abakalov@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=624904
==========

commit-bot: I haz the power

Description was changed from ========== Revert of Switching from the old language detector (CLD2) to ...

4 years, 4 months ago (2016-08-11 19:22:47 UTC) #6

Message was sent while issue was closed.

Description was changed from

==========
Revert of Switching from the old language detector (CLD2) to the new one (CLD3)
(patchset #1 id:1 of https://codereview.chromium.org/2243433002/ )

Reason for revert:
Causing build failure:
https://build.chromium.org/p/chromium/builders/Mac/builds/18465

Error message:
# language_identifier_features.cc
_GLOBAL__sub_I_language_identifier_features.cc+0x9a
# language_identifier_features.cc
chrome_lang_id::RegistryMetadata::Register(chrome_lang_id::RegistryMetadata*)
# language_identifier_features.cc
_ZN14chrome_lang_id17RegisterableClassINS_15FeatureFunctionINS_8SentenceEJEEEE9registry_E
# language_identifier_features.cc
chrome_lang_id::__ContinuousBagOfNgramsFunction__factory()
# language_identifier_features.cc
chrome_lang_id::__ContinuousBagOfNgramsFunction__registrar
# language_identifier_features.cc
chrome_lang_id::__ContinuousBagOfNgramsFunction__registrar+0x10
# language_identifier_features.cc
chrome_lang_id::__ContinuousBagOfNgramsFunction__registrar+0x18
# language_identifier_features.cc
chrome_lang_id::__ContinuousBagOfNgramsFunction__registrar+0x20
# language_identifier_features.cc
chrome_lang_id::__ContinuousBagOfNgramsFunction__registrar+0x28
# language_identifier_features.cc operator new[](unsigned long)
# language_identifier_features.cc sqlite3VXPrintf.zOrd+0x1b67aa
# language_identifier_features.cc sqlite3VXPrintf.zOrd+0x1b67c3
# language_identifier_features.cc sqlite3VXPrintf.zOrd+0x1b67e1

Original issue's description:
> Switching from the old language detector (CLD2) to the new one (CLD3)
> 
> BUG=624904
> 
> Committed: https://crrev.com/c2d06cc46ee69d6a90e9374c5b25ab4e4eaabe4f
> Cr-Commit-Position: refs/heads/master@{#411377}

TBR=andrewhayden@chromium.org,brettw@chromium.org,abakalov@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=624904
==========

to

==========
Revert of Switching from the old language detector (CLD2) to the new one (CLD3)
(patchset #1 id:1 of https://codereview.chromium.org/2243433002/ )

Reason for revert:
Causing build failure:
https://build.chromium.org/p/chromium/builders/Mac/builds/18465

Error message:
# language_identifier_features.cc
_GLOBAL__sub_I_language_identifier_features.cc+0x9a
# language_identifier_features.cc
chrome_lang_id::RegistryMetadata::Register(chrome_lang_id::RegistryMetadata*)
# language_identifier_features.cc
_ZN14chrome_lang_id17RegisterableClassINS_15FeatureFunctionINS_8SentenceEJEEEE9registry_E
# language_identifier_features.cc
chrome_lang_id::__ContinuousBagOfNgramsFunction__factory()
# language_identifier_features.cc
chrome_lang_id::__ContinuousBagOfNgramsFunction__registrar
# language_identifier_features.cc
chrome_lang_id::__ContinuousBagOfNgramsFunction__registrar+0x10
# language_identifier_features.cc
chrome_lang_id::__ContinuousBagOfNgramsFunction__registrar+0x18
# language_identifier_features.cc
chrome_lang_id::__ContinuousBagOfNgramsFunction__registrar+0x20
# language_identifier_features.cc
chrome_lang_id::__ContinuousBagOfNgramsFunction__registrar+0x28
# language_identifier_features.cc operator new[](unsigned long)
# language_identifier_features.cc sqlite3VXPrintf.zOrd+0x1b67aa
# language_identifier_features.cc sqlite3VXPrintf.zOrd+0x1b67c3
# language_identifier_features.cc sqlite3VXPrintf.zOrd+0x1b67e1

Original issue's description:
> Switching from the old language detector (CLD2) to the new one (CLD3)
>
> BUG=624904
>
> Committed: https://crrev.com/c2d06cc46ee69d6a90e9374c5b25ab4e4eaabe4f
> Cr-Commit-Position: refs/heads/master@{#411377}

TBR=andrewhayden@chromium.org,brettw@chromium.org,abakalov@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=624904

Committed: https://crrev.com/0987cdcc91f67119283908578bb74ca124af64cb
Cr-Commit-Position: refs/heads/master@{#411397}
==========

commit-bot: I haz the power

4 years, 4 months ago (2016-08-11 19:22:48 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/0987cdcc91f67119283908578bb74ca124af64cb
Cr-Commit-Position: refs/heads/master@{#411397}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages