Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 2237903003: mash: Migrate Shelf aura::Window uses to WmWindow. (Closed)

Created:
4 years, 4 months ago by msw
Modified:
4 years, 4 months ago
Reviewers:
James Cook, sky
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mash: Migrate Shelf aura::Window uses to WmWindow. Convert remaining Shelf aura::Window parameters to WmWindow. (TODO: move shelf files to eliminate internal aura::Window use) Move shelf notify functions to WmShell. Update callers. Misc cleanup. BUG=615155 TEST=Automated; no Chrome OS shelf regressions. R=jamescook@chromium.org TBR=sky@chromium.org Committed: https://crrev.com/61e1667efe869e8acb8bd72a4e7ad1a0f30236ce Cr-Commit-Position: refs/heads/master@{#411673}

Patch Set 1 #

Patch Set 2 : Convert Shelf::ForWindow parameter to WmWindow. #

Patch Set 3 : Move shelf notify functions to WmShell. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -165 lines) Patch
M ash/app_list/app_list_presenter_delegate.cc View 1 9 chunks +21 lines, -27 lines 0 comments Download
M ash/aura/wm_shelf_aura.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M ash/common/wm_shell.h View 1 2 1 chunk +16 lines, -6 lines 0 comments Download
M ash/common/wm_shell.cc View 1 2 1 chunk +16 lines, -1 line 0 comments Download
M ash/root_window_controller.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M ash/shelf/shelf.h View 1 3 chunks +3 lines, -7 lines 0 comments Download
M ash/shelf/shelf.cc View 1 2 6 chunks +16 lines, -20 lines 0 comments Download
M ash/shelf/shelf_view_unittest.cc View 1 2 5 chunks +9 lines, -6 lines 0 comments Download
M ash/shelf/shelf_widget_unittest.cc View 1 2 7 chunks +44 lines, -36 lines 0 comments Download
M ash/shell.h View 1 2 2 chunks +0 lines, -11 lines 0 comments Download
M ash/shell.cc View 1 2 2 chunks +0 lines, -15 lines 0 comments Download
M ash/wm/panels/panel_layout_manager_unittest.cc View 1 2 7 chunks +20 lines, -17 lines 0 comments Download
M ash/wm/window_animations.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M ash/wm/workspace/workspace_layout_manager_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/accessibility/accessibility_manager.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/accessibility/chromevox_panel.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc View 1 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc View 1 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/multi_user/user_switch_animator_chromeos.cc View 1 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/shelf_browsertest.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/window_sizer/window_sizer_ash_uitest.cc View 1 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 30 (23 generated)
msw
Hey James, please take a look; thanks!
4 years, 4 months ago (2016-08-12 15:02:54 UTC) #18
James Cook
LGTM
4 years, 4 months ago (2016-08-12 16:28:04 UTC) #19
msw
+TBR Scott for straightforward chrome/* changes; please take a look as you have time; thanks!
4 years, 4 months ago (2016-08-12 16:32:34 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2237903003/40001
4 years, 4 months ago (2016-08-12 16:32:53 UTC) #25
sky
chrome LGTM
4 years, 4 months ago (2016-08-12 16:36:32 UTC) #26
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-12 16:37:14 UTC) #28
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 16:41:15 UTC) #30
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/61e1667efe869e8acb8bd72a4e7ad1a0f30236ce
Cr-Commit-Position: refs/heads/master@{#411673}

Powered by Google App Engine
This is Rietveld 408576698