Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Side by Side Diff: src/objects.cc

Issue 22379002: Re-reland "Flush parallel recompilation queues on context dispose notification" (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: addressed more comments. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/liveedit.cc ('k') | src/optimizing-compiler-thread.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 9204 matching lines...) Expand 10 before | Expand all | Expand 10 after
9215 v->VisitCodeEntry(this->address() + kCodeEntryOffset); 9215 v->VisitCodeEntry(this->address() + kCodeEntryOffset);
9216 IteratePointers(v, kCodeEntryOffset + kPointerSize, object_size); 9216 IteratePointers(v, kCodeEntryOffset + kPointerSize, object_size);
9217 } 9217 }
9218 9218
9219 9219
9220 void JSFunction::MarkForLazyRecompilation() { 9220 void JSFunction::MarkForLazyRecompilation() {
9221 ASSERT(is_compiled() || GetIsolate()->DebuggerHasBreakPoints()); 9221 ASSERT(is_compiled() || GetIsolate()->DebuggerHasBreakPoints());
9222 ASSERT(!IsOptimized()); 9222 ASSERT(!IsOptimized());
9223 ASSERT(shared()->allows_lazy_compilation() || 9223 ASSERT(shared()->allows_lazy_compilation() ||
9224 code()->optimizable()); 9224 code()->optimizable());
9225 ASSERT(!shared()->is_generator());
9225 set_code_no_write_barrier( 9226 set_code_no_write_barrier(
9226 GetIsolate()->builtins()->builtin(Builtins::kLazyRecompile)); 9227 GetIsolate()->builtins()->builtin(Builtins::kLazyRecompile));
9227 // No write barrier required, since the builtin is part of the root set. 9228 // No write barrier required, since the builtin is part of the root set.
9228 } 9229 }
9229 9230
9230 9231
9231 void JSFunction::MarkForParallelRecompilation() { 9232 void JSFunction::MarkForParallelRecompilation() {
9232 ASSERT(is_compiled() || GetIsolate()->DebuggerHasBreakPoints()); 9233 ASSERT(is_compiled() || GetIsolate()->DebuggerHasBreakPoints());
9233 ASSERT(!IsOptimized()); 9234 ASSERT(!IsOptimized());
9234 ASSERT(shared()->allows_lazy_compilation() || code()->optimizable()); 9235 ASSERT(shared()->allows_lazy_compilation() || code()->optimizable());
9235 if (!FLAG_parallel_recompilation) { 9236 ASSERT(!shared()->is_generator());
9236 JSFunction::MarkForLazyRecompilation(); 9237 ASSERT(FLAG_parallel_recompilation);
9237 return;
9238 }
9239 if (FLAG_trace_parallel_recompilation) { 9238 if (FLAG_trace_parallel_recompilation) {
9240 PrintF(" ** Marking "); 9239 PrintF(" ** Marking ");
9241 PrintName(); 9240 PrintName();
9242 PrintF(" for parallel recompilation.\n"); 9241 PrintF(" for parallel recompilation.\n");
9243 } 9242 }
9244 set_code_no_write_barrier( 9243 set_code_no_write_barrier(
9245 GetIsolate()->builtins()->builtin(Builtins::kParallelRecompile)); 9244 GetIsolate()->builtins()->builtin(Builtins::kParallelRecompile));
9246 // No write barrier required, since the builtin is part of the root set. 9245 // No write barrier required, since the builtin is part of the root set.
9247 } 9246 }
9248 9247
(...skipping 6722 matching lines...) Expand 10 before | Expand all | Expand 10 after
15971 #define ERROR_MESSAGES_TEXTS(C, T) T, 15970 #define ERROR_MESSAGES_TEXTS(C, T) T,
15972 static const char* error_messages_[] = { 15971 static const char* error_messages_[] = {
15973 ERROR_MESSAGES_LIST(ERROR_MESSAGES_TEXTS) 15972 ERROR_MESSAGES_LIST(ERROR_MESSAGES_TEXTS)
15974 }; 15973 };
15975 #undef ERROR_MESSAGES_TEXTS 15974 #undef ERROR_MESSAGES_TEXTS
15976 return error_messages_[reason]; 15975 return error_messages_[reason];
15977 } 15976 }
15978 15977
15979 15978
15980 } } // namespace v8::internal 15979 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/liveedit.cc ('k') | src/optimizing-compiler-thread.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698