Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/compiler.cc

Issue 22379002: Re-reland "Flush parallel recompilation queues on context dispose notification" (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: addressed more comments. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/api.cc ('k') | src/debug.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 954 matching lines...) Expand 10 before | Expand all | Expand 10 after
965 ASSERT(closure->IsMarkedForParallelRecompilation()); 965 ASSERT(closure->IsMarkedForParallelRecompilation());
966 966
967 Isolate* isolate = closure->GetIsolate(); 967 Isolate* isolate = closure->GetIsolate();
968 // Here we prepare compile data for the parallel recompilation thread, but 968 // Here we prepare compile data for the parallel recompilation thread, but
969 // this still happens synchronously and interrupts execution. 969 // this still happens synchronously and interrupts execution.
970 Logger::TimerEventScope timer( 970 Logger::TimerEventScope timer(
971 isolate, Logger::TimerEventScope::v8_recompile_synchronous); 971 isolate, Logger::TimerEventScope::v8_recompile_synchronous);
972 972
973 if (!isolate->optimizing_compiler_thread()->IsQueueAvailable()) { 973 if (!isolate->optimizing_compiler_thread()->IsQueueAvailable()) {
974 if (FLAG_trace_parallel_recompilation) { 974 if (FLAG_trace_parallel_recompilation) {
975 PrintF(" ** Compilation queue, will retry opting on next run.\n"); 975 PrintF(" ** Compilation queue full, will retry optimizing ");
976 closure->PrintName();
977 PrintF(" on next run.\n");
976 } 978 }
977 return; 979 return;
978 } 980 }
979 981
980 SmartPointer<CompilationInfo> info(new CompilationInfoWithZone(closure)); 982 SmartPointer<CompilationInfo> info(new CompilationInfoWithZone(closure));
981 VMState<COMPILER> state(isolate); 983 VMState<COMPILER> state(isolate);
982 PostponeInterruptsScope postpone(isolate); 984 PostponeInterruptsScope postpone(isolate);
983 985
984 Handle<SharedFunctionInfo> shared = info->shared_info(); 986 Handle<SharedFunctionInfo> shared = info->shared_info();
985 int compiled_size = shared->end_position() - shared->start_position(); 987 int compiled_size = shared->end_position() - shared->start_position();
(...skipping 267 matching lines...) Expand 10 before | Expand all | Expand 10 after
1253 // Trace if the appropriate trace flag is set and the phase name's first 1255 // Trace if the appropriate trace flag is set and the phase name's first
1254 // character is in the FLAG_trace_phase command line parameter. 1256 // character is in the FLAG_trace_phase command line parameter.
1255 bool tracing_on = info()->IsStub() ? 1257 bool tracing_on = info()->IsStub() ?
1256 FLAG_trace_hydrogen_stubs : 1258 FLAG_trace_hydrogen_stubs :
1257 FLAG_trace_hydrogen; 1259 FLAG_trace_hydrogen;
1258 return (tracing_on && 1260 return (tracing_on &&
1259 OS::StrChr(const_cast<char*>(FLAG_trace_phase), name_[0]) != NULL); 1261 OS::StrChr(const_cast<char*>(FLAG_trace_phase), name_[0]) != NULL);
1260 } 1262 }
1261 1263
1262 } } // namespace v8::internal 1264 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/api.cc ('k') | src/debug.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698