Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2237883002: [serializer] checksum a larger part of the code snapshot. (Closed)

Created:
4 years, 4 months ago by Yang
Modified:
4 years, 4 months ago
Reviewers:
ahaas
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[serializer] checksum a larger part of the code snapshot. So far we only snapshot the payload data for the deserializer, but not the data for heap reservation or the code stub keys. At the same time this change turns some CHECKs that fail in the wild to DCHECKs. We can try turning them back to CHECKs some other time. TBR=ahaas@chromium.org BUG=chromium:636876 Committed: https://crrev.com/c84b850954a166e74913a4527d7991bdd2fd4722 Cr-Commit-Position: refs/heads/master@{#38594}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M src/snapshot/code-serializer.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/snapshot/code-serializer.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M src/snapshot/deserializer.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Yang
4 years, 4 months ago (2016-08-11 15:18:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2237883002/20001
4 years, 4 months ago (2016-08-12 05:08:04 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-12 05:09:43 UTC) #10
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/c84b850954a166e74913a4527d7991bdd2fd4722 Cr-Commit-Position: refs/heads/master@{#38594}
4 years, 4 months ago (2016-08-12 05:09:58 UTC) #12
ahaas
4 years, 4 months ago (2016-08-12 06:42:47 UTC) #13
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698