Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 223783006: Mojo: Make Channel take a RawChannel rather than creating it. (Closed)

Created:
6 years, 8 months ago by viettrungluu
Modified:
6 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Mojo: Make Channel take a RawChannel rather than creating it. This better decouples things, and will offer some flexibility that we may need shortly. R=sky@chromium.org, darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261560

Patch Set 1 #

Total comments: 1

Patch Set 2 : spurious space #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -98 lines) Patch
M mojo/embedder/embedder.cc View 2 chunks +3 lines, -1 line 0 comments Download
M mojo/system/channel.h View 1 chunk +3 lines, -5 lines 0 comments Download
M mojo/system/channel.cc View 1 2 chunks +5 lines, -8 lines 0 comments Download
M mojo/system/multiprocess_message_pipe_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M mojo/system/raw_channel.h View 3 chunks +12 lines, -11 lines 0 comments Download
M mojo/system/raw_channel.cc View 2 chunks +13 lines, -6 lines 0 comments Download
M mojo/system/raw_channel_posix.cc View 3 chunks +6 lines, -12 lines 0 comments Download
M mojo/system/raw_channel_unittest.cc View 8 chunks +23 lines, -41 lines 0 comments Download
M mojo/system/raw_channel_win.cc View 3 chunks +6 lines, -12 lines 0 comments Download
M mojo/system/remote_message_pipe_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
viettrungluu
6 years, 8 months ago (2014-04-03 19:45:17 UTC) #1
viettrungluu
-> sky
6 years, 8 months ago (2014-04-03 22:31:31 UTC) #2
sky
LGTM https://codereview.chromium.org/223783006/diff/1/mojo/system/channel.cc File mojo/system/channel.cc (right): https://codereview.chromium.org/223783006/diff/1/mojo/system/channel.cc#newcode40 mojo/system/channel.cc:40: bool Channel:: Init(scoped_ptr<RawChannel> raw_channel) { nit: spurious space.
6 years, 8 months ago (2014-04-03 22:34:28 UTC) #3
viettrungluu
spurious space
6 years, 8 months ago (2014-04-03 22:52:51 UTC) #4
viettrungluu
6 years, 8 months ago (2014-04-03 22:54:40 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r261560 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698