Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: tools/gn/functions_unittest.cc

Issue 223783005: Add support for reading .gypi files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/function_read_file.cc ('k') | tools/gn/input_conversion.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/functions_unittest.cc
diff --git a/tools/gn/functions_unittest.cc b/tools/gn/functions_unittest.cc
index 74ca6054a0b081ea3907315f0eefe27380e8ea38..3f6a6a9bea69b64ea3810e8c6cccce59ce29b925 100644
--- a/tools/gn/functions_unittest.cc
+++ b/tools/gn/functions_unittest.cc
@@ -11,7 +11,6 @@
TEST(Functions, Defined) {
TestWithScope setup;
- //InputFile input_file(SourceFile("//foo"));
FunctionCallNode function_call;
Err err;
@@ -27,8 +26,9 @@ TEST(Functions, Defined) {
// Define a value that's itself a scope value.
const char kDef[] = "def"; // Defined variable name.
- Scope nested(setup.scope());
- setup.scope()->SetValue(kDef, Value(NULL, &nested), NULL);
+ setup.scope()->SetValue(kDef,
+ Value(NULL, scoped_ptr<Scope>(new Scope(setup.scope()))),
+ NULL);
// Test the defined identifier.
Token defined_token(Location(), Token::IDENTIFIER, kDef);
« no previous file with comments | « tools/gn/function_read_file.cc ('k') | tools/gn/input_conversion.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698