Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Unified Diff: chrome/test/data/webui/settings/site_settings_category_tests.js

Issue 2237823003: Site Settings Desktop: Implement USB devices section. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address feedback Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/site_settings_helper.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/webui/settings/site_settings_category_tests.js
diff --git a/chrome/test/data/webui/settings/site_settings_category_tests.js b/chrome/test/data/webui/settings/site_settings_category_tests.js
index d926b56d6e43f243af3d441d7256b7b15d120af4..8f68198dab0f84f77cccac440c596595c0ab81e8 100644
--- a/chrome/test/data/webui/settings/site_settings_category_tests.js
+++ b/chrome/test/data/webui/settings/site_settings_category_tests.js
@@ -103,10 +103,23 @@ cr.define('site_settings_category', function() {
for (var key in settings.ContentSettingsTypes) {
var category = settings.ContentSettingsTypes[key];
- // All top-level categories must have category text ids and
- // descriptions. Categories that only appear under Site Details don't
- // need that.
- if (category != settings.ContentSettingsTypes.FULLSCREEN) {
+ // A quick testing note on a few special categories...
+
+ // Full Screen is not a top-level category, and only appears as a
+ // permission under Site Details. Therefore it has no Category Desc
+ // that can be tested for.
+
+ // The USB Devices category has no global toggle -- and therefore no
+ // Category Desc (and has a special way of storing its data).
+
+ // The Protocol Handlers is a special category in that is does not
+ // store its data like the rest, but it has a global default toggle
+ // and therefore can be tested like the rest below.
+
+ // Test category text ids and descriptions for those categories that
+ // have those.
+ if (category != settings.ContentSettingsTypes.FULLSCREEN &&
+ category != settings.ContentSettingsTypes.USB_DEVICES) {
assertNotEquals('', testElement.computeCategoryTextId(category));
assertNotEquals(
« no previous file with comments | « chrome/browser/ui/webui/site_settings_helper.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698