WebRTC: Add gyp_script parameter to ios recipe module's run_mb call.

WebRTC: Add gyp_script parameter to ios recipe module's run_mb call.

This will make it possible to specify a non-default GYP script to invoke
when running MB. See trybot results in 
https://codereview.webrtc.org/2239643002/ for more background
(tries to run build/gyp_chromium).

Also update the webrtc/ios expectations with 'mb_type' which was missing
(thus not resulting in MB being executed).

BUG=589510
Committed: https://chromium.googlesource.com/chromium/tools/build/+/34fd8200ebd17d56fb8b8edf7fa29ce70aff6ee4

[kjellander_chromium, 2016-08-11 09:13:27]

Description was changed from

==========
WebRTC: Add gyp_script parameter ios recipe module's run_mb call.

This will make it possible to specify a non-default GYP script to invoke
when running MB.
Also update the webrtc/ios expectations with 'mb_type' which was missing
(thus not resulting in MB being executed).

BUG=589510
==========

to

==========
WebRTC: Add gyp_script parameter to ios recipe module's run_mb call.

This will make it possible to specify a non-default GYP script to invoke
when running MB.
Also update the webrtc/ios expectations with 'mb_type' which was missing
(thus not resulting in MB being executed).

BUG=589510
==========

[kjellander_chromium, 2016-08-11 09:13:27]

kjellander@chromium.org changed reviewers:
+ phajdan.jr@chromium.org

[kjellander_chromium, 2016-08-11 09:16:26]

The CQ bit was checked by kjellander@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-11 09:16:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kjellander_chromium, 2016-08-11 09:21:11]

Description was changed from

==========
WebRTC: Add gyp_script parameter to ios recipe module's run_mb call.

This will make it possible to specify a non-default GYP script to invoke
when running MB.
Also update the webrtc/ios expectations with 'mb_type' which was missing
(thus not resulting in MB being executed).

BUG=589510
==========

to

==========
WebRTC: Add gyp_script parameter to ios recipe module's run_mb call.

This will make it possible to specify a non-default GYP script to invoke
when running MB. See trybot results in 
https://codereview.webrtc.org/2239643002/ for more background
(tries to run build/gyp_chromium).

Also update the webrtc/ios expectations with 'mb_type' which was missing
(thus not resulting in MB being executed).

BUG=589510
==========

[commit-bot: I haz the power, 2016-08-11 09:23:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 09:23:01]

Dry run: This issue passed the CQ dry run.

[kjellander_chromium, 2016-08-11 09:26:41]

kjellander@chromium.org changed reviewers:
+ ehmaldonado@chromium.org

[kjellander_chromium, 2016-08-11 09:26:42]

ehmaldonado: main review.
phajdan: rubberstamp for the scripts/slave/recipe_modules/ios/api.py change.

[ehmaldonado_chromium, 2016-08-11 09:39:11]

lgtm

https://codereview.chromium.org/2237793002/diff/1/scripts/slave/recipes/webrt...
File scripts/slave/recipes/webrtc/ios.py (right):

https://codereview.chromium.org/2237793002/diff/1/scripts/slave/recipes/webrt...
scripts/slave/recipes/webrtc/ios.py:68: 'compiler': 'ninja',
Shouldn't there be a 'mb_type': 'gyp' here as well?

[kjellander_chromium, 2016-08-11 09:49:59]

https://codereview.chromium.org/2237793002/diff/1/scripts/slave/recipes/webrt...
File scripts/slave/recipes/webrtc/ios.py (right):

https://codereview.chromium.org/2237793002/diff/1/scripts/slave/recipes/webrt...
scripts/slave/recipes/webrtc/ios.py:68: 'compiler': 'ninja',
On 2016/08/11 09:39:11, ehmaldonado_chromium wrote:
> Shouldn't there be a 'mb_type': 'gyp' here as well?

Good catch! Updated in PS#2.

[Paweł Hajdan Jr., 2016-08-11 09:50:23]

LGTM

[kjellander_chromium, 2016-08-11 09:55:18]

The CQ bit was checked by kjellander@chromium.org

[kjellander_chromium, 2016-08-11 09:55:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
ehmaldonado@chromium.org
Link to the patchset: https://codereview.chromium.org/2237793002/#ps20001
(title: "Updated last expectation")

[commit-bot: I haz the power, 2016-08-11 09:55:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 09:59:48]

Description was changed from

==========
WebRTC: Add gyp_script parameter to ios recipe module's run_mb call.

This will make it possible to specify a non-default GYP script to invoke
when running MB. See trybot results in 
https://codereview.webrtc.org/2239643002/ for more background
(tries to run build/gyp_chromium).

Also update the webrtc/ios expectations with 'mb_type' which was missing
(thus not resulting in MB being executed).

BUG=589510
==========

to

==========
WebRTC: Add gyp_script parameter to ios recipe module's run_mb call.

This will make it possible to specify a non-default GYP script to invoke
when running MB. See trybot results in 
https://codereview.webrtc.org/2239643002/ for more background
(tries to run build/gyp_chromium).

Also update the webrtc/ios expectations with 'mb_type' which was missing
(thus not resulting in MB being executed).

BUG=589510

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/34fd8200ebd17d56fb8b...
==========

[commit-bot: I haz the power, 2016-08-11 09:59:49]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/build/+/34fd8200ebd17d56fb8b...