Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 2237713002: MD Downloads: ignore empty URLs (Closed)

Created:
4 years, 4 months ago by Dan Beam
Modified:
4 years, 4 months ago
Reviewers:
mmenke
CC:
chromium-reviews, asanka, dbeam+watch-downloads_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Downloads: ignore empty URLs R=mmenke@chromium.org BUG=635220 Committed: https://crrev.com/d7f1230e51b779d8f81b140be7cd9db8734d5841 Cr-Commit-Position: refs/heads/master@{#411242}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/ui/webui/md_downloads/downloads_list_tracker.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Dan Beam
4 years, 4 months ago (2016-08-11 01:16:48 UTC) #1
mmenke
LGTM, that works. Doesn't look like there's a test fixture for it (Though this is ...
4 years, 4 months ago (2016-08-11 01:20:05 UTC) #2
Dan Beam
On 2016/08/11 01:20:05, mmenke wrote: > LGTM, that works. Doesn't look like there's a test ...
4 years, 4 months ago (2016-08-11 01:21:26 UTC) #3
Dan Beam
On 2016/08/11 01:21:26, Dan Beam wrote: > On 2016/08/11 01:20:05, mmenke wrote: > > LGTM, ...
4 years, 4 months ago (2016-08-11 01:21:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2237713002/1
4 years, 4 months ago (2016-08-11 01:22:52 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-11 03:04:31 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 03:07:47 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d7f1230e51b779d8f81b140be7cd9db8734d5841
Cr-Commit-Position: refs/heads/master@{#411242}

Powered by Google App Engine
This is Rietveld 408576698