Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(729)

Unified Diff: third_party/WebKit/Source/devtools/front_end/elements/ColorSwatchPopoverIcon.js

Issue 2237663002: DevTools: Use png icon for bezier editor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/elements/ColorSwatchPopoverIcon.js
diff --git a/third_party/WebKit/Source/devtools/front_end/elements/ColorSwatchPopoverIcon.js b/third_party/WebKit/Source/devtools/front_end/elements/ColorSwatchPopoverIcon.js
index ccc42c2023cafe7731b82ba5e7bb0857eacda85f..6b42eaafbe34f78188905fc90caf6a1917a4fdf7 100644
--- a/third_party/WebKit/Source/devtools/front_end/elements/ColorSwatchPopoverIcon.js
+++ b/third_party/WebKit/Source/devtools/front_end/elements/ColorSwatchPopoverIcon.js
@@ -32,17 +32,13 @@ WebInspector.BezierPopoverIcon.prototype = {
*/
_createDOM: function(text)
{
- this._element = createElement("nobr");
+ this._element = createElement("span");
- this._iconElement = this._element.createChild("div", "popover-icon bezier-icon");
+ this._iconElement = this._element.createChild("span", "bezier-icon");
+ var root = WebInspector.createShadowRootWithCoreStyles(this._iconElement, "ui/bezierSwatch.css");
lushnikov 2016/08/10 23:42:13 let's put these three lines by themselves: WebIn
flandy 2016/08/11 01:37:59 Done.
+ root.createChild("span", "bezier-swatch");
this._iconElement.title = WebInspector.UIString("Open cubic bezier editor");
- var svg = this._iconElement.createSVGChild("svg");
- svg.setAttribute("height", 10);
- svg.setAttribute("width", 10);
this._iconElement.addEventListener("click", this._iconClick.bind(this), false);
- var g = svg.createSVGChild("g");
- var path = g.createSVGChild("path");
- path.setAttribute("d", "M2,8 C2,3 8,7 8,2");
this._bezierValueElement = this._element.createChild("span");
this._bezierValueElement.textContent = text;

Powered by Google App Engine
This is Rietveld 408576698