Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(973)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2237643003: [layoutng] Add a base class for layout algorithms (Closed)

Created:
4 years, 4 months ago by cbiesinger
Modified:
4 years, 4 months ago
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[layoutng] Add a base class for layout algorithms R=ikilpatrick@chromium.org,eae@chromium.org,glebl@chromium.org BUG=635619 Committed: https://crrev.com/4447e60b8218f0fb2e16d30844ac129419bc95b5 Cr-Commit-Position: refs/heads/master@{#411240}

Patch Set 1 #

Patch Set 2 : fast alloc and noncopyable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -2 lines) Patch
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h View 3 chunks +3 lines, -2 lines 0 comments Download
A third_party/WebKit/Source/core/layout/ng/ng_layout_algorithm.h View 1 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
cbiesinger
4 years, 4 months ago (2016-08-10 23:25:34 UTC) #1
eae
LGTM
4 years, 4 months ago (2016-08-10 23:29:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2237643003/20001
4 years, 4 months ago (2016-08-10 23:45:16 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-11 03:00:14 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 03:03:17 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/4447e60b8218f0fb2e16d30844ac129419bc95b5
Cr-Commit-Position: refs/heads/master@{#411240}

Powered by Google App Engine
This is Rietveld 408576698