Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(845)

Issue 2237633002: Removing proguard -keep which does nothing (Closed)

Created:
4 years, 4 months ago by smaier
Modified:
4 years, 4 months ago
Reviewers:
agrieve
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removing proguard -keep which does nothing We already turned off the dangerous optimization that breaks this library. This is redundant. BUG=619937 Committed: https://crrev.com/6429e31ec1e178090e74fbe2ebf92b0db21432fc Cr-Commit-Position: refs/heads/master@{#411342}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M chrome/android/java/proguard.flags View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
smaier
4 years, 4 months ago (2016-08-10 20:05:05 UTC) #2
agrieve
On 2016/08/10 20:05:05, smaier wrote: lgtm
4 years, 4 months ago (2016-08-10 20:36:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2237633002/1
4 years, 4 months ago (2016-08-11 14:32:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-11 16:03:21 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 16:06:36 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6429e31ec1e178090e74fbe2ebf92b0db21432fc
Cr-Commit-Position: refs/heads/master@{#411342}

Powered by Google App Engine
This is Rietveld 408576698