Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/arm64/lithium-arm64.cc

Issue 223763003: Fixed environment assignment for LCheckNonSmi. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Rebased Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/lithium-arm.cc ('k') | src/ia32/lithium-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1153 matching lines...) Expand 10 before | Expand all | Expand 10 after
1164 } 1164 }
1165 } 1165 }
1166 } 1166 }
1167 UNREACHABLE(); 1167 UNREACHABLE();
1168 return NULL; 1168 return NULL;
1169 } 1169 }
1170 1170
1171 1171
1172 LInstruction* LChunkBuilder::DoCheckValue(HCheckValue* instr) { 1172 LInstruction* LChunkBuilder::DoCheckValue(HCheckValue* instr) {
1173 LOperand* value = UseRegisterAtStart(instr->value()); 1173 LOperand* value = UseRegisterAtStart(instr->value());
1174 return AssignEnvironment(new(zone()) LCheckValue(value)); 1174 LInstruction* result = new(zone()) LCheckNonSmi(value);
1175 if (!instr->value()->IsHeapObject()) result = AssignEnvironment(result);
1176 return result;
1175 } 1177 }
1176 1178
1177 1179
1178 LInstruction* LChunkBuilder::DoCheckInstanceType(HCheckInstanceType* instr) { 1180 LInstruction* LChunkBuilder::DoCheckInstanceType(HCheckInstanceType* instr) {
1179 LOperand* value = UseRegisterAtStart(instr->value()); 1181 LOperand* value = UseRegisterAtStart(instr->value());
1180 LOperand* temp = TempRegister(); 1182 LOperand* temp = TempRegister();
1181 LInstruction* result = new(zone()) LCheckInstanceType(value, temp); 1183 LInstruction* result = new(zone()) LCheckInstanceType(value, temp);
1182 return AssignEnvironment(result); 1184 return AssignEnvironment(result);
1183 } 1185 }
1184 1186
(...skipping 1376 matching lines...) Expand 10 before | Expand all | Expand 10 after
2561 2563
2562 LInstruction* LChunkBuilder::DoWrapReceiver(HWrapReceiver* instr) { 2564 LInstruction* LChunkBuilder::DoWrapReceiver(HWrapReceiver* instr) {
2563 LOperand* receiver = UseRegister(instr->receiver()); 2565 LOperand* receiver = UseRegister(instr->receiver());
2564 LOperand* function = UseRegister(instr->function()); 2566 LOperand* function = UseRegister(instr->function());
2565 LWrapReceiver* result = new(zone()) LWrapReceiver(receiver, function); 2567 LWrapReceiver* result = new(zone()) LWrapReceiver(receiver, function);
2566 return AssignEnvironment(DefineAsRegister(result)); 2568 return AssignEnvironment(DefineAsRegister(result));
2567 } 2569 }
2568 2570
2569 2571
2570 } } // namespace v8::internal 2572 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/arm/lithium-arm.cc ('k') | src/ia32/lithium-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698