third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc - Issue 2237623002: Demo patch that demonstrates simple block layout using Layout NG

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc

Issue 2237623002: Demo patch that demonstrates simple block layout using Layout NG (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixed NGBlockLayoutAlgorithmTest Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc ('k') | third_party/WebKit/Source/core/layout/ng/ng_box.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc b/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc

index f008d686370ed2844e0e40f2442916bc5c17a0e6..b15ae8296321560aa521bdbb880e58194698dd70 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc

+++ b/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc

@@ -4,7 +4,7 @@

#include "core/layout/ng/ng_block_layout_algorithm.h"

-#include "core/layout/ng/ng_box.h"

+#include "core/layout/ng/ng_box_iterator.h"

#include "core/layout/ng/ng_constraint_space.h"

#include "core/layout/ng/ng_fragment.h"

#include "core/style/ComputedStyle.h"

@@ -28,7 +28,7 @@ TEST_F(NGBlockLayoutAlgorithmTest, FixedSize) {

NGConstraintSpace space(LayoutUnit(100), LayoutUnit(-1));

- NGBlockLayoutAlgorithm algorithm(style_, NGBox(nullptr));

+ NGBlockLayoutAlgorithm algorithm(style_, NGBoxIterator(nullptr));

NGFragment* frag = algorithm.layout(space);

EXPECT_EQ(frag->inlineSize(), LayoutUnit(30));

EXPECT_EQ(frag->blockSize(), LayoutUnit(40));