Demo patch that demonstrates simple block layout using Layout NG

Demo patch that demonstrates simple block layout using Layout NG

This also includes NGBoxIterator for-loop iterator to iterate over sibling children of layout object.

BUG=635619
Committed: https://crrev.com/d71da6eb5c6b03bf76679ea6d88f08ea78c0e86e
Cr-Commit-Position: refs/heads/master@{#411403}

[Gleb Lanbin, 2016-08-11 15:25:54]

Patchset #1 (id:1) has been deleted

[Gleb Lanbin, 2016-08-11 15:26:19]

Description was changed from

==========
Layout NG try out.

BUG=
==========

to

==========
Layout NG try out.

BUG=635619
==========

[Gleb Lanbin, 2016-08-11 15:30:20]

Patchset #1 (id:20001) has been deleted

[Gleb Lanbin, 2016-08-11 15:37:05]

Description was changed from

==========
Layout NG try out.

BUG=635619
==========

to

==========
Demo patch that demonstrates simple block layout using Layout NG

This also includes NGBoxIterator for-loop iterator to iterate over sibling
children of layout object.

BUG=635619
==========

[Gleb Lanbin, 2016-08-11 15:37:42]

Patchset #1 (id:40001) has been deleted

[Gleb Lanbin, 2016-08-11 15:38:11]

glebl@chromium.org changed reviewers:
+ cbiesinger@chromium.org, eae@chromium.org, ikilpatrick@chromium.org

[Gleb Lanbin, 2016-08-11 15:38:18]

The CQ bit was checked by glebl@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-11 15:38:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eae, 2016-08-11 15:40:49]

https://codereview.chromium.org/2237623002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/ng/ng_box.cc (right):

https://codereview.chromium.org/2237623002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_box.cc:19:
toLayoutBox(m_layoutObject)->setLogicalWidth(fragement->inlineSize());
We probably want to add a fragment->size method and use
setLogicalSize(fragment->size()). Let's do that in a separate CL though.

[Gleb Lanbin, 2016-08-11 16:08:16]

https://codereview.chromium.org/2237623002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/ng/ng_box.cc (right):

https://codereview.chromium.org/2237623002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/ng_box.cc:19:
toLayoutBox(m_layoutObject)->setLogicalWidth(fragement->inlineSize());
On 2016/08/11 15:40:49, eae wrote:
> We probably want to add a fragment->size method and use
> setLogicalSize(fragment->size()). Let's do that in a separate CL though.

Acknowledged.

[Gleb Lanbin, 2016-08-11 16:08:22]

The CQ bit was checked by glebl@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-11 16:09:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Gleb Lanbin, 2016-08-11 16:11:00]

Patchset #2 (id:80001) has been deleted

[cbiesinger, 2016-08-11 16:37:44]

lgtm

[ikilpatrick, 2016-08-11 16:40:12]

lgtm with nits delivered in person :)

[Gleb Lanbin, 2016-08-11 16:42:35]

The CQ bit was checked by glebl@chromium.org

[Gleb Lanbin, 2016-08-11 16:42:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
cbiesinger@chromium.org, ikilpatrick@chromium.org
Link to the patchset: https://codereview.chromium.org/2237623002/#ps120001
(title: "fix a couple of nits")

[commit-bot: I haz the power, 2016-08-11 16:42:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 18:04:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 18:04:34]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Gleb Lanbin, 2016-08-11 18:15:10]

The CQ bit was checked by glebl@chromium.org

[Gleb Lanbin, 2016-08-11 18:15:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
cbiesinger@chromium.org, ikilpatrick@chromium.org
Link to the patchset: https://codereview.chromium.org/2237623002/#ps140001
(title: "fixed NGBlockLayoutAlgorithmTest")

[commit-bot: I haz the power, 2016-08-11 18:15:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 19:42:29]

Description was changed from

==========
Demo patch that demonstrates simple block layout using Layout NG

This also includes NGBoxIterator for-loop iterator to iterate over sibling
children of layout object.

BUG=635619
==========

to

==========
Demo patch that demonstrates simple block layout using Layout NG

This also includes NGBoxIterator for-loop iterator to iterate over sibling
children of layout object.

BUG=635619
==========

[commit-bot: I haz the power, 2016-08-11 19:42:30]

Committed patchset #4 (id:140001)

[commit-bot: I haz the power, 2016-08-11 19:44:01]

Description was changed from

==========
Demo patch that demonstrates simple block layout using Layout NG

This also includes NGBoxIterator for-loop iterator to iterate over sibling
children of layout object.

BUG=635619
==========

to

==========
Demo patch that demonstrates simple block layout using Layout NG

This also includes NGBoxIterator for-loop iterator to iterate over sibling
children of layout object.

BUG=635619

Committed: https://crrev.com/d71da6eb5c6b03bf76679ea6d88f08ea78c0e86e
Cr-Commit-Position: refs/heads/master@{#411403}
==========

[commit-bot: I haz the power, 2016-08-11 19:44:02]

Patchset 4 (id:??) landed as
https://crrev.com/d71da6eb5c6b03bf76679ea6d88f08ea78c0e86e
Cr-Commit-Position: refs/heads/master@{#411403}