Add support for operational arguments protobuf.

Add support for operational arguments protobuf.

This adds an "arguments.proto" protobuf, which is consumed by
"recipes.py" for operational argument input. The "--timestamps" flag and
"run" sub-command's "properties" parameter are initially implemented by
this protobuf.

BUG=chromium:628770
TEST=local
  - Ran locally w/ JSON file, works.
  - Wrote unit test, works locally.

Committed: https://github.com/luci/recipes-py/commit/aa5141a2236738b8a3d0e0fa57e1220066df29a4

[dnj, 2016-08-10 19:16:52]

dnj@chromium.org changed reviewers:
+ iannucci@chromium.org, martiniss@chromium.org

[dnj, 2016-08-10 19:16:53]

PTAL. This should impose no functionality changes, but stages this option in
anticipation of additional operational arguments being added in future CLs.

[martiniss, 2016-08-10 21:38:25]

https://codereview.chromium.org/2237593002/diff/20001/recipe_engine/arguments...
File recipe_engine/arguments.proto (right):

https://codereview.chromium.org/2237593002/diff/20001/recipe_engine/arguments...
recipe_engine/arguments.proto:6: // protoc -I recipe_engine
recipe_engine/package.proto --python_out=recipe_engine
Do we need this? You put this here, right? This should be automatically
recompiled by the bootstrap script.

https://codereview.chromium.org/2237593002/diff/20001/recipe_engine/arguments...
recipe_engine/arguments.proto:18: oneof value {
What about lists? Currently for the recipe roller, we have a list of strings of
projects we want to roll. How would I represent this in this protobuf?

https://codereview.chromium.org/2237593002/diff/20001/recipes.py
File recipes.py (right):

https://codereview.chromium.org/2237593002/diff/20001/recipes.py#newcode246
recipes.py:246: """Adds an arguments_pb2.PropertyList entry into a dictionary.
"into a dictionary"? This returns a dictionary...

https://codereview.chromium.org/2237593002/diff/20001/recipes.py#newcode462
recipes.py:462: # Load/parse operational arguments.
Why is this done down here, vs in the run function?

https://codereview.chromium.org/2237593002/diff/20001/unittests/args_test.py
File unittests/args_test.py (right):

https://codereview.chromium.org/2237593002/diff/20001/unittests/args_test.py#...
unittests/args_test.py:1: #!/usr/bin/env python
Could you rename this file to be unittests/recipes_py_test.py? I think there's a
case for some testing of recipes.py in general, so this file would contain other
tests like that.

[dnj, 2016-08-10 22:04:41]

https://codereview.chromium.org/2237593002/diff/20001/recipe_engine/arguments...
File recipe_engine/arguments.proto (right):

https://codereview.chromium.org/2237593002/diff/20001/recipe_engine/arguments...
recipe_engine/arguments.proto:6: // protoc -I recipe_engine
recipe_engine/package.proto --python_out=recipe_engine
On 2016/08/10 21:38:25, martiniss wrote:
> Do we need this? You put this here, right? This should be automatically
> recompiled by the bootstrap script.

Oops, yeah no.

https://codereview.chromium.org/2237593002/diff/20001/recipe_engine/arguments...
recipe_engine/arguments.proto:18: oneof value {
On 2016/08/10 21:38:25, martiniss wrote:
> What about lists? Currently for the recipe roller, we have a list of strings
of
> projects we want to roll. How would I represent this in this protobuf?

I wasn't aware of those. I'll add list.

https://codereview.chromium.org/2237593002/diff/20001/recipes.py
File recipes.py (right):

https://codereview.chromium.org/2237593002/diff/20001/recipes.py#newcode246
recipes.py:246: """Adds an arguments_pb2.PropertyList entry into a dictionary.
On 2016/08/10 21:38:25, martiniss wrote:
> "into a dictionary"? This returns a dictionary... 

Acknowledged.

https://codereview.chromium.org/2237593002/diff/20001/recipes.py#newcode462
recipes.py:462: # Load/parse operational arguments.
On 2016/08/10 21:38:25, martiniss wrote:
> Why is this done down here, vs in the run function?

The idea is that the operational parameters may sometime be used by something
other than the run function. If you don't think this is going to be the case,
I'll move it to a run parameter and evaluate it there.

https://codereview.chromium.org/2237593002/diff/20001/unittests/args_test.py
File unittests/args_test.py (right):

https://codereview.chromium.org/2237593002/diff/20001/unittests/args_test.py#...
unittests/args_test.py:1: #!/usr/bin/env python
On 2016/08/10 21:38:25, martiniss wrote:
> Could you rename this file to be unittests/recipes_py_test.py? I think there's
a
> case for some testing of recipes.py in general, so this file would contain
other
> tests like that.

Okay.

[martiniss, 2016-08-10 22:54:45]

lgtm

https://codereview.chromium.org/2237593002/diff/40001/recipes.py
File recipes.py (right):

https://codereview.chromium.org/2237593002/diff/40001/recipes.py#newcode245
recipes.py:245: # Map of arguments_pb2.Property "value" oneof conversion
functions.
Add comment saying "Keep in sync with recipe_engine/arguments.proto"?

[dnj, 2016-08-11 01:21:31]

https://codereview.chromium.org/2237593002/diff/40001/recipes.py
File recipes.py (right):

https://codereview.chromium.org/2237593002/diff/40001/recipes.py#newcode245
recipes.py:245: # Map of arguments_pb2.Property "value" oneof conversion
functions.
On 2016/08/10 22:54:45, martiniss wrote:
> Add comment saying "Keep in sync with recipe_engine/arguments.proto"?

Done.

[dnj, 2016-08-11 01:21:35]

The CQ bit was checked by dnj@chromium.org

[dnj, 2016-08-11 01:21:36]

The patchset sent to the CQ was uploaded after l-g-t-m from
martiniss@chromium.org
Link to the patchset: https://codereview.chromium.org/2237593002/#ps60001
(title: "Comment for oneof map.")

[commit-bot: I haz the power, 2016-08-11 01:21:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 01:24:15]

Description was changed from

==========
Add support for operational arguments protobuf.

This adds an "arguments.proto" protobuf, which is consumed by
"recipes.py" for operational argument input. The "--timestamps" flag and
"run" sub-command's "properties" parameter are initially implemented by
this protobuf.

BUG=chromium:628770
TEST=local
  - Ran locally w/ JSON file, works.
  - Wrote unit test, works locally.
==========

to

==========
Add support for operational arguments protobuf.

This adds an "arguments.proto" protobuf, which is consumed by
"recipes.py" for operational argument input. The "--timestamps" flag and
"run" sub-command's "properties" parameter are initially implemented by
this protobuf.

BUG=chromium:628770
TEST=local
  - Ran locally w/ JSON file, works.
  - Wrote unit test, works locally.

Committed:
https://github.com/luci/recipes-py/commit/aa5141a2236738b8a3d0e0fa57e1220066d...
==========

[commit-bot: I haz the power, 2016-08-11 01:24:15]

Committed patchset #4 (id:60001) as
https://github.com/luci/recipes-py/commit/aa5141a2236738b8a3d0e0fa57e1220066d...