Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2237573004:
Change chrome://settings strings for ARC OptIn. (Closed)
|
Created:
4 years, 4 months ago by Josh Horwich Modified:
4 years, 4 months ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionChange chrome://settings strings for ARC OptIn.
Simple wording changes to strings in chrome://settings related to ARC
OptIn section, to align with other documentation.
BUG=b:30773667
TEST=Visit chrome://settings
Committed: https://crrev.com/7aaac36d6f2dc840e9857baab6a324b53de718ce
Cr-Commit-Position: refs/heads/master@{#411382}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Modify description strings as well. #Messages
Total messages: 17 (11 generated)
The CQ bit was checked by jhorwich@chromium.org to run a CQ dry run
Description was changed from ========== Change chrome://settings strings for ARC OptIn. Simple wording changes to strings in chrome://settings related to ARC OptIn section, to align with other documentation. BUG=b:30773667 TEST=Visit chrome://settings ========== to ========== Change chrome://settings strings for ARC OptIn. Simple wording changes to strings in chrome://settings related to ARC OptIn section, to align with other documentation. BUG=b:30773667 TEST=Visit chrome://settings ==========
jhorwich@chromium.org changed reviewers: + elijahtaylor@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
ptal
jhorwich@chromium.org changed reviewers: + govind@chromium.org
lgtm https://codereview.chromium.org/2237573004/diff/1/chrome/app/chromeos_strings... File chrome/app/chromeos_strings.grdp (right): https://codereview.chromium.org/2237573004/diff/1/chrome/app/chromeos_strings... chrome/app/chromeos_strings.grdp:6824: <message name="IDS_OPTIONS_ARC_TITLE" desc="The title of Android Apps section."> probably worth changing the translation messages as well, unless we've been told not to
https://codereview.chromium.org/2237573004/diff/1/chrome/app/chromeos_strings... File chrome/app/chromeos_strings.grdp (right): https://codereview.chromium.org/2237573004/diff/1/chrome/app/chromeos_strings... chrome/app/chromeos_strings.grdp:6824: <message name="IDS_OPTIONS_ARC_TITLE" desc="The title of Android Apps section."> On 2016/08/11 16:55:04, elijahtaylor1 wrote: > probably worth changing the translation messages as well, unless we've been told > not to Done.
The CQ bit was checked by jhorwich@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from elijahtaylor@chromium.org Link to the patchset: https://codereview.chromium.org/2237573004/#ps20001 (title: "Modify description strings as well.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Change chrome://settings strings for ARC OptIn. Simple wording changes to strings in chrome://settings related to ARC OptIn section, to align with other documentation. BUG=b:30773667 TEST=Visit chrome://settings ========== to ========== Change chrome://settings strings for ARC OptIn. Simple wording changes to strings in chrome://settings related to ARC OptIn section, to align with other documentation. BUG=b:30773667 TEST=Visit chrome://settings ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Change chrome://settings strings for ARC OptIn. Simple wording changes to strings in chrome://settings related to ARC OptIn section, to align with other documentation. BUG=b:30773667 TEST=Visit chrome://settings ========== to ========== Change chrome://settings strings for ARC OptIn. Simple wording changes to strings in chrome://settings related to ARC OptIn section, to align with other documentation. BUG=b:30773667 TEST=Visit chrome://settings Committed: https://crrev.com/7aaac36d6f2dc840e9857baab6a324b53de718ce Cr-Commit-Position: refs/heads/master@{#411382} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/7aaac36d6f2dc840e9857baab6a324b53de718ce Cr-Commit-Position: refs/heads/master@{#411382} |
