Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutTableRowTest.cpp

Issue 2237573003: Disable flaky LayoutTableCellDeathTest and LayoutTableRowDeathTest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: LayoutTableRowDeathTest. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutTableCellTest.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 29 matching lines...) Expand all
40 } 40 }
41 41
42 virtual void TearDown() 42 virtual void TearDown()
43 { 43 {
44 m_row->destroy(); 44 m_row->destroy();
45 } 45 }
46 46
47 LayoutTableRow* m_row; 47 LayoutTableRow* m_row;
48 }; 48 };
49 49
50 TEST_F(LayoutTableRowDeathTest, CanSetRow) 50 // TODO(esprehn): Disabled all of these tests because they're flaky: crbug.com/6 30625
51 TEST_F(LayoutTableRowDeathTest, DISABLED_CanSetRow)
51 { 52 {
52 static const unsigned rowIndex = 10; 53 static const unsigned rowIndex = 10;
53 m_row->setRowIndex(rowIndex); 54 m_row->setRowIndex(rowIndex);
54 EXPECT_EQ(rowIndex, m_row->rowIndex()); 55 EXPECT_EQ(rowIndex, m_row->rowIndex());
55 } 56 }
56 57
57 TEST_F(LayoutTableRowDeathTest, CanSetRowToMaxRowIndex) 58 TEST_F(LayoutTableRowDeathTest, DISABLED_CanSetRowToMaxRowIndex)
58 { 59 {
59 m_row->setRowIndex(maxRowIndex); 60 m_row->setRowIndex(maxRowIndex);
60 EXPECT_EQ(maxRowIndex, m_row->rowIndex()); 61 EXPECT_EQ(maxRowIndex, m_row->rowIndex());
61 } 62 }
62 63
63 // FIXME: Re-enable these tests once ASSERT_DEATH is supported for Android. 64 // FIXME: Re-enable these tests once ASSERT_DEATH is supported for Android.
64 // See: https://bugs.webkit.org/show_bug.cgi?id=74089 65 // See: https://bugs.webkit.org/show_bug.cgi?id=74089
65 #if !OS(ANDROID) 66 #if !OS(ANDROID)
66 67
67 TEST_F(LayoutTableRowDeathTest, CrashIfRowOverflowOnSetting) 68 TEST_F(LayoutTableRowDeathTest, DISABLED_CrashIfRowOverflowOnSetting)
68 { 69 {
69 ASSERT_DEATH(m_row->setRowIndex(maxRowIndex + 1), ""); 70 ASSERT_DEATH(m_row->setRowIndex(maxRowIndex + 1), "");
70 } 71 }
71 72
72 TEST_F(LayoutTableRowDeathTest, CrashIfSettingUnsetRowIndex) 73 TEST_F(LayoutTableRowDeathTest, DISABLED_CrashIfSettingUnsetRowIndex)
73 { 74 {
74 ASSERT_DEATH(m_row->setRowIndex(unsetRowIndex), ""); 75 ASSERT_DEATH(m_row->setRowIndex(unsetRowIndex), "");
75 } 76 }
76 77
77 #endif 78 #endif
78 79
79 using LayoutTableRowTest = RenderingTest; 80 using LayoutTableRowTest = RenderingTest;
80 81
81 TEST_F(LayoutTableRowTest, BackgroundIsKnownToBeOpaqueWithLayerAndCollapsedBorde r) 82 TEST_F(LayoutTableRowTest, BackgroundIsKnownToBeOpaqueWithLayerAndCollapsedBorde r)
82 { 83 {
(...skipping 22 matching lines...) Expand all
105 "<tr style='background-color: blue'><td>Cell</td><td>Cell</td></tr>" 106 "<tr style='background-color: blue'><td>Cell</td><td>Cell</td></tr>"
106 "</table>"); 107 "</table>");
107 108
108 LayoutTableRow* row = toLayoutTableRow(document().body()->firstChild()->firs tChild()->firstChild()->layoutObject()); 109 LayoutTableRow* row = toLayoutTableRow(document().body()->firstChild()->firs tChild()->firstChild()->layoutObject());
109 EXPECT_FALSE(row->backgroundIsKnownToBeOpaqueInRect(LayoutRect(0, 0, 1, 1))) ; 110 EXPECT_FALSE(row->backgroundIsKnownToBeOpaqueInRect(LayoutRect(0, 0, 1, 1))) ;
110 } 111 }
111 112
112 } // anonymous namespace 113 } // anonymous namespace
113 114
114 } // namespace blink 115 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutTableCellTest.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698