Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutTableCellTest.cpp

Issue 2237573003: Disable flaky LayoutTableCellDeathTest and LayoutTableRowDeathTest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: LayoutTableRowDeathTest. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutTableRowTest.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 29 matching lines...) Expand all
40 } 40 }
41 41
42 virtual void TearDown() 42 virtual void TearDown()
43 { 43 {
44 m_cell->destroy(); 44 m_cell->destroy();
45 } 45 }
46 46
47 LayoutTableCell* m_cell; 47 LayoutTableCell* m_cell;
48 }; 48 };
49 49
50 TEST_F(LayoutTableCellDeathTest, CanSetColumn) 50 // TODO(esprehn): Disabled all of these tests because they're flaky: crbug.com/6 30625
51 TEST_F(LayoutTableCellDeathTest, DISABLED_CanSetColumn)
51 { 52 {
52 static const unsigned columnIndex = 10; 53 static const unsigned columnIndex = 10;
53 m_cell->setAbsoluteColumnIndex(columnIndex); 54 m_cell->setAbsoluteColumnIndex(columnIndex);
54 EXPECT_EQ(columnIndex, m_cell->absoluteColumnIndex()); 55 EXPECT_EQ(columnIndex, m_cell->absoluteColumnIndex());
55 } 56 }
56 57
57 TEST_F(LayoutTableCellDeathTest, CanSetColumnToMaxColumnIndex) 58 TEST_F(LayoutTableCellDeathTest, DISABLED_CanSetColumnToMaxColumnIndex)
58 { 59 {
59 m_cell->setAbsoluteColumnIndex(maxColumnIndex); 60 m_cell->setAbsoluteColumnIndex(maxColumnIndex);
60 EXPECT_EQ(maxColumnIndex, m_cell->absoluteColumnIndex()); 61 EXPECT_EQ(maxColumnIndex, m_cell->absoluteColumnIndex());
61 } 62 }
62 63
63 // FIXME: Re-enable these tests once ASSERT_DEATH is supported for Android. 64 // FIXME: Re-enable these tests once ASSERT_DEATH is supported for Android.
64 // See: https://bugs.webkit.org/show_bug.cgi?id=74089 65 // See: https://bugs.webkit.org/show_bug.cgi?id=74089
65 #if !OS(ANDROID) 66 #if !OS(ANDROID)
66 67
67 TEST_F(LayoutTableCellDeathTest, CrashIfColumnOverflowOnSetting) 68 TEST_F(LayoutTableCellDeathTest, DISABLED_CrashIfColumnOverflowOnSetting)
68 { 69 {
69 ASSERT_DEATH(m_cell->setAbsoluteColumnIndex(maxColumnIndex + 1), ""); 70 ASSERT_DEATH(m_cell->setAbsoluteColumnIndex(maxColumnIndex + 1), "");
70 } 71 }
71 72
72 TEST_F(LayoutTableCellDeathTest, CrashIfSettingUnsetColumnIndex) 73 TEST_F(LayoutTableCellDeathTest, DISABLED_CrashIfSettingUnsetColumnIndex)
73 { 74 {
74 ASSERT_DEATH(m_cell->setAbsoluteColumnIndex(unsetColumnIndex), ""); 75 ASSERT_DEATH(m_cell->setAbsoluteColumnIndex(unsetColumnIndex), "");
75 } 76 }
76 77
77 #endif 78 #endif
78 79
79 using LayoutTableCellTest = RenderingTest; 80 using LayoutTableCellTest = RenderingTest;
80 81
81 TEST_F(LayoutTableCellTest, ResetColspanIfTooBig) 82 TEST_F(LayoutTableCellTest, ResetColspanIfTooBig)
82 { 83 {
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
140 document().view()->updateAllLifecyclePhases(); 141 document().view()->updateAllLifecyclePhases();
141 142
142 // Check that overflow was calculated on the cell. 143 // Check that overflow was calculated on the cell.
143 LayoutBlock* inputBlock = toLayoutBlock(getLayoutObjectByElementId("cell")); 144 LayoutBlock* inputBlock = toLayoutBlock(getLayoutObjectByElementId("cell"));
144 LayoutRect rect = inputBlock->localOverflowRectForPaintInvalidation(); 145 LayoutRect rect = inputBlock->localOverflowRectForPaintInvalidation();
145 EXPECT_EQ(rect, LayoutRect(-1, -1, 24, 24)); 146 EXPECT_EQ(rect, LayoutRect(-1, -1, 24, 24));
146 } 147 }
147 } // namespace 148 } // namespace
148 149
149 } // namespace blink 150 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutTableRowTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698