src/full-codegen/x64/full-codegen-x64.cc - Issue 2237553004: Use IsPropertyName instead of IsInternalizedString in VisitObjectLiteral.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/x64/full-codegen-x64.cc

Issue 2237553004: Use IsPropertyName instead of IsInternalizedString in VisitObjectLiteral. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/full-codegen/x64/full-codegen-x64.cc

diff --git a/src/full-codegen/x64/full-codegen-x64.cc b/src/full-codegen/x64/full-codegen-x64.cc

index e491e98a2635096b40ee71938d03fb4c7e122560..a9c20dc84c98c03ad0b7156f274414b67228b9c5 100644

--- a/src/full-codegen/x64/full-codegen-x64.cc

+++ b/src/full-codegen/x64/full-codegen-x64.cc

@@ -1384,7 +1384,7 @@ void FullCodeGenerator::VisitObjectLiteral(ObjectLiteral* expr) {

case ObjectLiteral::Property::COMPUTED:

// It is safe to use [[Put]] here because the boilerplate already

// contains computed properties with an uninitialized value.

- if (key->value()->IsInternalizedString()) {

+ if (key->IsPropertyName()) {

if (property->emit_store()) {

VisitForAccumulatorValue(value);

DCHECK(StoreDescriptor::ValueRegister().is(rax));

« no previous file with comments | « src/full-codegen/s390/full-codegen-s390.cc ('k') | src/interpreter/bytecode-generator.cc » ('j') | no next file with comments »