Issue 2237553002: [M53] Adjust MediaControls for effective zoom when dropping controls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2237553002: [M53] Adjust MediaControls for effective zoom when dropping controls. (Closed)

Created:
4 years, 4 months ago by liberato (no reviews please)

Modified:
4 years, 4 months ago

Reviewers:
mlamouri (slow - plz ping)

CC:
chromium-reviews, nessy, mlamouri+watch-blink_chromium.org, blink-reviews-html_chromium.org, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, blink-reviews, vcarbune.chromium

Base URL:
https://chromium.googlesource.com/chromium/src.git@2785

Target Ref:
refs/pending/branch-heads/2785

Project:
chromium

Visibility:
Public.

More Reviews

Description

[M53] Adjust MediaControls for effective zoom when dropping controls. This is a merge of https://codereview.chromium.org/2219673004 . When computing how many controls fit in the media control panel, the effective zoom was ignored. This caused the control width to appear to change as they zoomed, even though the available space in the bar also changed proportionally. The effect was that zooming would change which controls were visible in the panel. This CL adjusts for the ComputedStyle's effective zoom. BUG=630466 TEST=media-controls-fit-properly-while-zoomed.html TBR=mlamouri@chromium.org NOPRESUBMIT=true NOTRY=true

Patch Set 1 #

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+37 lines, -4 lines)			Patch
M	third_party/WebKit/LayoutTests/TestExpectations	View	2 chunks	+1 line, -1 line	0 comments	Download
A	third_party/WebKit/LayoutTests/media/media-controls-fit-properly-while-zoomed.html	View	1 chunk	+31 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/html/shadow/MediaControls.cpp	View	1 chunk	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2237553002/1

4 years, 4 months ago (2016-08-10 17:30:55 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages