Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2237543002: Improve error reporting: use colors and associate the appropiate file with (Closed)

Created:
4 years, 4 months ago by Siggi Cherem (dart-lang)
Modified:
4 years, 4 months ago
Reviewers:
Harry Terkelsen
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Improve error reporting: use colors and associate the appropiate file with bazel-root uris. The latter makes it possible to show errors that highlight the original source code. BUG= R=het@google.com Committed: https://github.com/dart-lang/sdk/commit/e71fa2b05c251bd20410d7da65a8222b2817d443

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M pkg/compiler/bin/resolver.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/source_file_provider.dart View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Siggi Cherem (dart-lang)
4 years, 4 months ago (2016-08-10 17:22:44 UTC) #2
Harry Terkelsen
lgtm
4 years, 4 months ago (2016-08-10 21:40:03 UTC) #3
Siggi Cherem (dart-lang)
4 years, 4 months ago (2016-08-10 21:41:14 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e71fa2b05c251bd20410d7da65a8222b2817d443 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698