Add checkbox to allow auto signing in with a saved password.

Add checkbox to allow auto signing in with a saved password.

Screenshot attached to bug.

BUG=620002
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/671bc0128ed34a0c7c0095bcbf21fd6759c66275
Cr-Commit-Position: refs/heads/master@{#412614}

[hcarmona, 2016-08-10 17:13:42]

Description was changed from

==========
Add checkbox to allow auto signing in with a saved password.

Screenshot attached to bug.

BUG=620002
==========

to

==========
Add checkbox to allow auto signing in with a saved password.

Screenshot attached to bug.

BUG=620002
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[hcarmona, 2016-08-10 17:13:48]

The CQ bit was checked by hcarmona@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 17:14:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hcarmona, 2016-08-10 17:19:30]

hcarmona@chromium.org changed reviewers:
+ michaelpg@chromium.org

[hcarmona, 2016-08-10 17:19:31]

PTAL

bettes@ is going to give feedback on screenshot. We can review this and I can
make changes he suggests as a separate CL.

[commit-bot: I haz the power, 2016-08-10 17:26:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 17:26:27]

Dry run: Try jobs failed on following builders:
  closure_compilation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)

[hcarmona, 2016-08-10 17:28:54]

The CQ bit was checked by hcarmona@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 17:30:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 19:41:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 19:41:54]

Dry run: This issue passed the CQ dry run.

[michaelpg, 2016-08-12 21:51:28]

https://codereview.chromium.org/2237533002/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
(right):

https://codereview.chromium.org/2237533002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html:58:
<settings-checkbox id="autosigninCheckbox"
autosignin or autoSignIn or autoSignin, don't care which, just please be
consistent throughout the CL... makes it easier to maintain without introducing
bugs :-)

https://codereview.chromium.org/2237533002/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js
(right):

https://codereview.chromium.org/2237533002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js:24:
PrefsBehavior,
is this necessary?

https://codereview.chromium.org/2237533002/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
(right):

https://codereview.chromium.org/2237533002/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc:809:
IDS_SETTINGS_PASSWORDS_AUTO_SIGNIN_CHECKBOX_LABEL},
align w/ " here & below

also, make AUTO_SIGNIN underscores also match the capitalization chosen above

[hcarmona, 2016-08-16 22:03:00]

The CQ bit was checked by hcarmona@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 22:03:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hcarmona, 2016-08-16 22:17:58]

The CQ bit was checked by hcarmona@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 22:18:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hcarmona, 2016-08-16 22:23:44]

Patchset #3 (id:30001) has been deleted

[hcarmona, 2016-08-16 22:33:40]

Sorry it took me a while to get back to you on this, I was hoping to
address bette@'s UI feedback, but that will need to be a separate CL.

https://codereview.chromium.org/2237533002/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
(right):

https://codereview.chromium.org/2237533002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html:58:
<settings-checkbox id="autosigninCheckbox"
On 2016/08/12 21:51:28, michaelpg wrote:
> autosignin or autoSignIn or autoSignin, don't care which, just please be
> consistent throughout the CL... makes it easier to maintain without
introducing
> bugs :-)

All changed to autosignin to match setting.

https://codereview.chromium.org/2237533002/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js
(right):

https://codereview.chromium.org/2237533002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js:24:
PrefsBehavior,
On 2016/08/12 21:51:28, michaelpg wrote:
> is this necessary?

Nope. Removed.

https://codereview.chromium.org/2237533002/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
(right):

https://codereview.chromium.org/2237533002/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc:809:
IDS_SETTINGS_PASSWORDS_AUTO_SIGNIN_CHECKBOX_LABEL},
On 2016/08/12 21:51:28, michaelpg wrote:
> align w/ " here & below
> 
> also, make AUTO_SIGNIN underscores also match the capitalization chosen above

Done.

[michaelpg, 2016-08-16 23:21:26]

lgtm

https://codereview.chromium.org/2237533002/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
(right):

https://codereview.chromium.org/2237533002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html:58:
<settings-checkbox id="autosigninCheckbox"
On 2016/08/16 22:33:39, Hector Carmona wrote:
> On 2016/08/12 21:51:28, michaelpg wrote:
> > autosignin or autoSignIn or autoSignin, don't care which, just please be
> > consistent throughout the CL... makes it easier to maintain without
> introducing
> > bugs :-)
> 
> All changed to autosignin to match setting.

Thanks. It's a pet peeve of mine -- I had to wage a small war to get "Sign in"
and "Sign-in" used properly in our English strings.

[commit-bot: I haz the power, 2016-08-16 23:24:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 23:24:07]

Dry run: This issue passed the CQ dry run.

[hcarmona, 2016-08-17 19:30:55]

The CQ bit was checked by hcarmona@chromium.org

[commit-bot: I haz the power, 2016-08-17 19:31:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 19:37:24]

Committed patchset #3 (id:50001)

[commit-bot: I haz the power, 2016-08-17 19:42:49]

Description was changed from

==========
Add checkbox to allow auto signing in with a saved password.

Screenshot attached to bug.

BUG=620002
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Add checkbox to allow auto signing in with a saved password.

Screenshot attached to bug.

BUG=620002
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/671bc0128ed34a0c7c0095bcbf21fd6759c66275
Cr-Commit-Position: refs/heads/master@{#412614}
==========

[commit-bot: I haz the power, 2016-08-17 19:42:51]

Patchset 3 (id:??) landed as
https://crrev.com/671bc0128ed34a0c7c0095bcbf21fd6759c66275
Cr-Commit-Position: refs/heads/master@{#412614}