Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Unified Diff: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

Issue 2237503002: Reject play promises when the playback reaches the end. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
index 477cbbbd0a63ee29b73920abdcffb48bba5588b0..41cb9f8ca61697ee8159d6daaaa4b820b02e375c 100644
--- a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
@@ -2913,6 +2913,7 @@ void HTMLMediaElement::timeChanged()
// changes paused to true and fires a simple event named pause at the media element.
m_paused = true;
scheduleEvent(EventTypeNames::pause);
+ scheduleRejectPlayPromises(AbortError);
foolip 2016/08/18 20:16:17 Add a TODO to add event firing and rejection in th
mlamouri (slow - plz ping) 2016/08/19 09:26:29 It is bug 587871. Given that we never bundle promi
}
// Queue a task to fire a simple event named ended at the media element.
scheduleEvent(EventTypeNames::ended);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698