Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2237483002: Stop pointing to "gn help toolchain" in that very help message. (Closed)

Created:
4 years, 4 months ago by Raphael Kubo da Costa (rakuco)
Modified:
4 years, 4 months ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews, Dirk Pranke, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop pointing to "gn help toolchain" in that very help message. toolchain_args became a variable in commit 22227896 ("Update GN toolchain_args to be a variable"), but the help message was copy-pasted from when it was a separate function and referenced the toolchain function's help message. Remove that reference now that it is pointing to itself. R=brettw@chromium.org,dpranke@chromium.org BUG=634446 Committed: https://crrev.com/fcd8d221139567226dc07b8b94ebeae1f2b94134 Cr-Commit-Position: refs/heads/master@{#411115}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Patch v2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M tools/gn/function_toolchain.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Raphael Kubo da Costa (rakuco)
PTAL; I'm not sure if the entire paragraph should be reformatted now.
4 years, 4 months ago (2016-08-10 15:34:14 UTC) #1
brettw
Thanks for catching this. https://codereview.chromium.org/2237483002/diff/1/tools/gn/function_toolchain.cc File tools/gn/function_toolchain.cc (right): https://codereview.chromium.org/2237483002/diff/1/tools/gn/function_toolchain.cc#newcode324 tools/gn/function_toolchain.cc:324: " toolchain. toolchain_args allows you\n" ...
4 years, 4 months ago (2016-08-10 17:12:41 UTC) #2
Raphael Kubo da Costa (rakuco)
I've re-wrapped the text in patch v2.
4 years, 4 months ago (2016-08-10 17:35:04 UTC) #3
brettw
Thanks. LGTM
4 years, 4 months ago (2016-08-10 18:05:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2237483002/20001
4 years, 4 months ago (2016-08-10 18:11:20 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-10 19:39:01 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 19:40:52 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fcd8d221139567226dc07b8b94ebeae1f2b94134
Cr-Commit-Position: refs/heads/master@{#411115}

Powered by Google App Engine
This is Rietveld 408576698