Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(685)

Issue 2237473002: [heap] Fix LAB tests (Closed)

Created:
4 years, 4 months ago by Michael Lippautz
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Fix LAB tests Let's not write out of bounds here. R=hpayer@chromium.org BUG=chromium:636331 Committed: https://crrev.com/09e7c01b3139c1fa4ea45995a3b7b4a46b348efd Cr-Commit-Position: refs/heads/master@{#38547}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M test/cctest/heap/test-lab.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Michael Lippautz
4 years, 4 months ago (2016-08-10 15:21:01 UTC) #1
Hannes Payer (out of office)
lgtm
4 years, 4 months ago (2016-08-10 15:22:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2237473002/1
4 years, 4 months ago (2016-08-10 15:56:05 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-10 15:57:51 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 15:58:12 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/09e7c01b3139c1fa4ea45995a3b7b4a46b348efd
Cr-Commit-Position: refs/heads/master@{#38547}

Powered by Google App Engine
This is Rietveld 408576698