Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(778)

Issue 2237433002: ash: Use stl utilities from the base namespace (Closed)

Created:
4 years, 4 months ago by Sami
Modified:
4 years, 4 months ago
Reviewers:
Daniel Erat
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ash: Use stl utilities from the base namespace The utilities in base/stl_util.h have been moved from the global into the base namespace. This patch updates the call sites accordingly. No functional changes. BUG=636301 Committed: https://crrev.com/773ba699a46e9fa747d295b5ba1005ac6b5fbf11 Cr-Commit-Position: refs/heads/master@{#411605}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -17 lines) Patch
M ash/common/accelerators/accelerator_router.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/common/wm/maximize_mode/maximize_mode_window_manager.cc View 6 chunks +8 lines, -7 lines 0 comments Download
M ash/display/display_animator_chromeos.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/display/display_color_manager_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/display/window_tree_host_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/test/test_session_state_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/utility/screenshot_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/screen_pinning_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/system_modal_container_layout_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/multi_window_resize_controller_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 19 (14 generated)
Sami
PTAL.
4 years, 4 months ago (2016-08-10 14:26:26 UTC) #7
Daniel Erat
lgtm
4 years, 4 months ago (2016-08-10 15:09:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2237433002/20001
4 years, 4 months ago (2016-08-12 12:04:46 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-12 12:08:56 UTC) #17
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 12:10:58 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/773ba699a46e9fa747d295b5ba1005ac6b5fbf11
Cr-Commit-Position: refs/heads/master@{#411605}

Powered by Google App Engine
This is Rietveld 408576698