Maybehandlification of EnsureJSArrayWithWritableFastElements().

Maybehandlification of EnsureJSArrayWithWritableFastElements().

R=yangguo@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=20498

[Igor Sheludko, 2014-04-03 14:56:40]

PTAL

[Yang, 2014-04-03 15:04:03]

https://codereview.chromium.org/223743003/diff/1/src/builtins.cc
File src/builtins.cc (right):

https://codereview.chromium.org/223743003/diff/1/src/builtins.cc#newcode399
src/builtins.cc:399: Handle<FixedArrayBase> elms_obj =
maybe_elms_obj.ToHandleChecked();
That would be a duplicate check. Why not use ToHandle in the if-condition and
convert at the same time.
Same below.

[Igor Sheludko, 2014-04-03 15:17:06]

https://codereview.chromium.org/223743003/diff/1/src/builtins.cc
File src/builtins.cc (right):

https://codereview.chromium.org/223743003/diff/1/src/builtins.cc#newcode399
src/builtins.cc:399: Handle<FixedArrayBase> elms_obj =
maybe_elms_obj.ToHandleChecked();
On 2014/04/03 15:04:04, Yang wrote:
> That would be a duplicate check. Why not use ToHandle in the if-condition and
> convert at the same time.
> Same below.

Good point, done.

[Yang, 2014-04-04 08:00:06]

On 2014/04/03 15:17:06, Igor Sheludko wrote:
> https://codereview.chromium.org/223743003/diff/1/src/builtins.cc
> File src/builtins.cc (right):
> 
> https://codereview.chromium.org/223743003/diff/1/src/builtins.cc#newcode399
> src/builtins.cc:399: Handle<FixedArrayBase> elms_obj =
> maybe_elms_obj.ToHandleChecked();
> On 2014/04/03 15:04:04, Yang wrote:
> > That would be a duplicate check. Why not use ToHandle in the if-condition
and
> > convert at the same time.
> > Same below.
> 
> Good point, done.

lgtm.

[Igor Sheludko, 2014-04-04 08:17:50]

Committed patchset #2 manually as r20498 (presubmit successful).