Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 223743002: [New Multicolumn] Avoid freeze if column count is 1 and there's a forced break. (Closed)

Created:
6 years, 8 months ago by mstensho (USE GERRIT)
Modified:
6 years, 8 months ago
Reviewers:
ojan
CC:
blink-reviews, mstensho+blink_opera.com, zoltan1, dsinclair, bemjb+rendering_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr., rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

[New Multicolumn] Avoid freeze if column count is 1 and there's a forced break. If we don't have more columns available than the number of forced breaks, we're going to have to allow overflowing columns. No matter how tall we try to make the column set, there will be overflowing columns, so just give up. This used to work as long as column count was 2 or greater, but there was an unnecessary check that prevented it from working if column count was 1. This was especially bad since we actually stop counting forced breaks when we reach the number of columns available. BUG=359536 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170795

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -1 line) Patch
A LayoutTests/fast/multicol/one-column-with-break.html View 1 chunk +16 lines, -0 lines 0 comments Download
A LayoutTests/fast/multicol/one-column-with-break-expected.html View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderMultiColumnSet.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
mstensho (USE GERRIT)
6 years, 8 months ago (2014-04-03 11:20:01 UTC) #1
ojan
lgtm
6 years, 8 months ago (2014-04-03 19:53:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mstensho@opera.com/223743002/1
6 years, 8 months ago (2014-04-03 19:53:47 UTC) #3
commit-bot: I haz the power
6 years, 8 months ago (2014-04-03 21:01:08 UTC) #4
Message was sent while issue was closed.
Change committed as 170795

Powered by Google App Engine
This is Rietveld 408576698