 Chromium Code Reviews
 Chromium Code Reviews Issue 2237423002:
  [debugger] PrepareFunctionForBreakPoints handles both fcg code and bytecode.  (Closed) 
  Base URL: https://chromium.googlesource.com/v8/v8.git@master
    
  
    Issue 2237423002:
  [debugger] PrepareFunctionForBreakPoints handles both fcg code and bytecode.  (Closed) 
  Base URL: https://chromium.googlesource.com/v8/v8.git@master| OLD | NEW | 
|---|---|
| 1 // Copyright 2012 the V8 project authors. All rights reserved. | 1 // Copyright 2012 the V8 project authors. All rights reserved. | 
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be | 
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. | 
| 4 // | 4 // | 
| 5 // Review notes: | 5 // Review notes: | 
| 6 // | 6 // | 
| 7 // - The use of macros in these inline functions may seem superfluous | 7 // - The use of macros in these inline functions may seem superfluous | 
| 8 // but it is absolutely needed to make sure gcc generates optimal | 8 // but it is absolutely needed to make sure gcc generates optimal | 
| 9 // code. gcc is not happy when attempting to inline too deep. | 9 // code. gcc is not happy when attempting to inline too deep. | 
| 10 // | 10 // | 
| (...skipping 6154 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 6165 } | 6165 } | 
| 6166 | 6166 | 
| 6167 | 6167 | 
| 6168 DebugInfo* SharedFunctionInfo::GetDebugInfo() { | 6168 DebugInfo* SharedFunctionInfo::GetDebugInfo() { | 
| 6169 DCHECK(HasDebugInfo()); | 6169 DCHECK(HasDebugInfo()); | 
| 6170 return DebugInfo::cast(debug_info()); | 6170 return DebugInfo::cast(debug_info()); | 
| 6171 } | 6171 } | 
| 6172 | 6172 | 
| 6173 | 6173 | 
| 6174 bool SharedFunctionInfo::HasDebugCode() { | 6174 bool SharedFunctionInfo::HasDebugCode() { | 
| 6175 return HasBytecodeArray() || | 6175 if (HasBaselineCode()) return code()->has_debug_break_slots(); | 
| 6176 (HasBaselineCode() && code()->has_debug_break_slots()); | 6176 return HasBytecodeArray(); | 
| 
Michael Starzinger
2016/08/12 08:27:23
Just for my own confirmation, this should be the s
 
Yang
2016/08/12 08:31:27
Yes. What it says is: if we have fcg code, it need
 | |
| 6177 } | 6177 } | 
| 6178 | 6178 | 
| 6179 | 6179 | 
| 6180 bool SharedFunctionInfo::IsApiFunction() { | 6180 bool SharedFunctionInfo::IsApiFunction() { | 
| 6181 return function_data()->IsFunctionTemplateInfo(); | 6181 return function_data()->IsFunctionTemplateInfo(); | 
| 6182 } | 6182 } | 
| 6183 | 6183 | 
| 6184 | 6184 | 
| 6185 FunctionTemplateInfo* SharedFunctionInfo::get_api_func_data() { | 6185 FunctionTemplateInfo* SharedFunctionInfo::get_api_func_data() { | 
| 6186 DCHECK(IsApiFunction()); | 6186 DCHECK(IsApiFunction()); | 
| (...skipping 2021 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 8208 #undef WRITE_INT64_FIELD | 8208 #undef WRITE_INT64_FIELD | 
| 8209 #undef READ_BYTE_FIELD | 8209 #undef READ_BYTE_FIELD | 
| 8210 #undef WRITE_BYTE_FIELD | 8210 #undef WRITE_BYTE_FIELD | 
| 8211 #undef NOBARRIER_READ_BYTE_FIELD | 8211 #undef NOBARRIER_READ_BYTE_FIELD | 
| 8212 #undef NOBARRIER_WRITE_BYTE_FIELD | 8212 #undef NOBARRIER_WRITE_BYTE_FIELD | 
| 8213 | 8213 | 
| 8214 } // namespace internal | 8214 } // namespace internal | 
| 8215 } // namespace v8 | 8215 } // namespace v8 | 
| 8216 | 8216 | 
| 8217 #endif // V8_OBJECTS_INL_H_ | 8217 #endif // V8_OBJECTS_INL_H_ | 
| OLD | NEW |