scripts/slave/recipe_modules/goma/example.expected/win.json - Issue 2237403002: Add cloudtail start/stop in recipe_modules/goma

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/goma/example.expected/win.json

Issue 2237403002: Add cloudtail start/stop in recipe_modules/goma (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: remove a try-finally Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipe_modules/goma/example.expected/mac_upload_logs.json ('k') | scripts/slave/recipe_modules/goma/example.expected/win_upload_logs.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipe_modules/goma/example.expected/win.json

diff --git a/scripts/slave/recipe_modules/goma/example.expected/win.json b/scripts/slave/recipe_modules/goma/example.expected/win.json

index 973ae2ea4e7a48e5375a9cb7407c24754b8d71c6..c0e1fb2d665df4763b53a2803943baafca178ad5 100644

--- a/scripts/slave/recipe_modules/goma/example.expected/win.json

+++ b/scripts/slave/recipe_modules/goma/example.expected/win.json

@@ -69,6 +69,21 @@

"cmd": [

"python",

"-u",

+ "RECIPE_MODULE[build::goma]\\resources\\cloudtail_utils.py",

+ "start",

+ "--cloudtail-path",

+ "C:\\infra-tools\\cloudtail"

+ ],

+ "env": {

+ "GOMA_SERVICE_ACCOUNT_JSON_FILE": "C:\\creds\\service_accounts\\service-account-goma-client.json"

+ },

+ "name": "start cloudtail",

+ "stdout": "/path/to/tmp/"

+ },

+ {

+ "cmd": [

+ "python",

+ "-u",

"[CACHE]\\cipd\\goma\\goma_ctl.py",

"stop"

@@ -87,6 +102,17 @@

"name": "upload_log"

{

+ "cmd": [

+ "python",

+ "-u",

+ "RECIPE_MODULE[build::goma]\\resources\\cloudtail_utils.py",

+ "stop",

+ "--killed-pid",

+ "12345"

+ ],

+ "name": "stop cloudtail"

+ },

+ {

"name": "$result",

"recipe_result": null,

"status_code": 0