Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1678)

Unified Diff: scripts/slave/recipe_modules/goma/example.expected/mac_upload_logs.json

Issue 2237403002: Add cloudtail start/stop in recipe_modules/goma (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: remove a try-finally Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipe_modules/goma/example.expected/mac_upload_logs.json
diff --git a/scripts/slave/recipe_modules/goma/example.expected/mac_upload_logs.json b/scripts/slave/recipe_modules/goma/example.expected/mac_upload_logs.json
index e9faff75701a2fbe0b196c74e6b7ae528f576b1d..f248b09757e774fd559a1e4082f8391bebaecadf 100644
--- a/scripts/slave/recipe_modules/goma/example.expected/mac_upload_logs.json
+++ b/scripts/slave/recipe_modules/goma/example.expected/mac_upload_logs.json
@@ -71,6 +71,23 @@
"cmd": [
"python",
"-u",
+ "RECIPE_MODULE[build::goma]/resources/cloudtail_utils.py",
+ "start",
+ "--cloudtail-path",
+ "/opt/infra-tools/cloudtail"
+ ],
+ "env": {
+ "GOMACTL_CRASH_REPORT_ID_FILE": "build_data_dir/crash_report_id_file",
+ "GOMA_DUMP_STATS_FILE": "build_data_dir/goma_stats_proto",
+ "GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account-goma-client.json"
+ },
+ "name": "start cloudtail",
+ "stdout": "/path/to/tmp/"
+ },
+ {
+ "cmd": [
+ "python",
+ "-u",
"[CACHE]/cipd/goma/goma_ctl.py",
"stop"
],
@@ -105,6 +122,17 @@
"name": "upload_log"
},
{
+ "cmd": [
+ "python",
+ "-u",
+ "RECIPE_MODULE[build::goma]/resources/cloudtail_utils.py",
+ "stop",
+ "--killed-pid",
+ "12345"
+ ],
+ "name": "stop cloudtail"
+ },
+ {
"name": "$result",
"recipe_result": null,
"status_code": 0

Powered by Google App Engine
This is Rietveld 408576698