Add cloudtail start/stop in recipe_modules/goma

scripts/slave/recipe_modules/goma/resources/cloudtail_utils.py

+#!/usr/bin/env python
+# Copyright (c) 2016 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+import argparse
+import os
+import signal
+import subprocess
+import sys
+
+from slave import goma_utils
+
+
+def start_cloudtail(args):
+  """Write process id of started cloudtail to file object f"""
+
+  proc = subprocess.Popen([args.cloudtail_path,
+                           'tail',
+                           '--log-id', 'goma_compiler_proxy'
+                           '--path',
+                           goma_utils.GetLatestGomaCompilerProxyInfo()])
+
+  sys.stdout.write(str(proc.pid))
+
+
+def main():
+  parser = argparse.ArgumentParser(
+      description='cloudtail utility for goma recipe module.')
+
+  subparsers = parser.add_subparsers(help='commands for cloudtail')
+
+  parser_start = subparsers.add_parser('start',
+                                       help='subcommand to start cloudtail')
+  parser_start.set_defaults(command='start')
+  parser_start.add_argument('--cloudtail-path', required=True,
+                            help='path of cloudtail binary')
+
+  parser_stop = subparsers.add_parser('stop',
+                                      help='subcommand to stop cloudtail')
+  parser_stop.set_defaults(command='stop')
+  parser_stop.add_argument('--killed-pid', type=int, required=True,
+                           help='pid that is killed.')
+
+  args = parser.parse_args()
+
+  if args.command == 'start':
+    start_cloudtail(args)
+  elif args.command == 'stop':
+    killed_pid = args.killed_pid
+    # Only send SIGKILL signal, let init process do wait for killed_pid.

[Paweł Hajdan Jr., 2016/08/19 09:39:04]

nit: Is this comment really useful?

[tikuta, 2016/08/19 09:53:12]

Done.

+    os.kill(killed_pid, signal.SIGKILL)

[Paweł Hajdan Jr., 2016/08/19 09:39:04]

nit: Just use args.killed_pid here, no need for temp variable.

[tikuta, 2016/08/19 09:53:12]

Done.

+
+
+if '__main__' == __name__:
+  sys.exit(main())