Issue 223733004: [Android] Push data deps before listing gtests.

Issue 223733004: [Android] Push data deps before listing gtests. (Closed)

Created:
6 years, 8 months ago by jbudorick

Modified:
6 years, 8 months ago

Reviewers:
craigdh, frankf

CC:
chromium-reviews, klundberg+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

[Android] Push data deps before listing gtests. BUG=357771 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261633

Patch Set 2 : Address Craig's comments. #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -22 lines)			Patch
	M	build/android/pylib/gtest/setup.py	View	1	4 chunks	+28 lines, -17 lines	0 comments	Download
	M	build/android/pylib/gtest/test_runner.py	View	1	1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

jbudorick

This CL lists gtests by running a fake test through the normal test infrastructure, following ...

6 years, 8 months ago (2014-04-03 21:40:08 UTC) #1

craigdh

lgtm w/ nits https://codereview.chromium.org/223733004/diff/1/build/android/pylib/gtest/setup.py File build/android/pylib/gtest/setup.py (right): https://codereview.chromium.org/223733004/diff/1/build/android/pylib/gtest/setup.py#newcode223 build/android/pylib/gtest/setup.py:223: 'ListTheTests', base_test_result.ResultType.PASS) Since this only applies ...

6 years, 8 months ago (2014-04-03 21:58:06 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbudorick@chromium.org/223733004/20001

6 years, 8 months ago (2014-04-03 22:46:08 UTC) #4

Message was sent while issue was closed.

Change committed as 261633

Expand Messages | Collapse Messages