Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2237313003: Reland of Temporarily disable win audio quality tests. (Closed)

Created:
4 years, 4 months ago by ehmaldonado_chromium
Modified:
4 years, 4 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, tnakamura+watch_chromium.org, phoglund+watch_chromium.org, mcasas+watch+vc_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Temporarily disable win audio quality tests. (patchset #1 id:1 of https://codereview.chromium.org/2233943003/ ) Reason for revert: Both Win7 testers started failing when this test was re-eneabled: https://build.chromium.org/p/chromium.webrtc/builders/Win7%20Tester/builds/28513 https://build.chromium.org/p/chromium.webrtc.fyi/builders/Win7%20Tester/builds/5365 (the latter is harder to see since it's showing a webrtc repo blamelist, but if you check got_revision_cp property and compare with the previous build you can see that #411296 is in the range). Original issue's description: > Revert of Temporarily disable win audio quality tests. (patchset #1 id:1 of https://codereview.chromium.org/2127533002/ ) > > Reason for revert: > The bots seem to be correctly configured now. > > Original issue's description: > > Temporarily disable win audio quality tests. > > > > We need to have the bots re-imaged to win7 consumer first and then > > configured for loopback audio. > > > > BUG=625808 > > TBR=magjed@chromium.org > > > > Committed: https://crrev.com/4c2f75699ef1523b8a99eacdc6e6ef6f152828bc > > Cr-Commit-Position: refs/heads/master@{#403772} > > TBR=magjed@chromium.org,phoglund@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=625808 > > Committed: https://crrev.com/8f71a3001c5e3d72fecf41aab0a0db444022dac1 > Cr-Commit-Position: refs/heads/master@{#411296} TBR=magjed@chromium.org,phoglund@chromium.org,kjellander@chromium.org,tommi@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=625808 Committed: https://crrev.com/695991fb8e48cfabd7d269b1ff80a28f17c79806 Cr-Commit-Position: refs/heads/master@{#411596}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/media/webrtc_audio_quality_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
ehmaldonado_chromium
Created Reland of Temporarily disable win audio quality tests.
4 years, 4 months ago (2016-08-12 08:12:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2237313003/1
4 years, 4 months ago (2016-08-12 08:12:18 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 4 months ago (2016-08-12 08:12:26 UTC) #5
ehmaldonado_chromium
On 2016/08/12 08:12:26, commit-bot: I haz the power wrote: > No L-G-T-M from a valid ...
4 years, 4 months ago (2016-08-12 08:52:23 UTC) #7
tommi (sloooow) - chröme
lgtm
4 years, 4 months ago (2016-08-12 11:37:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2237313003/1
4 years, 4 months ago (2016-08-12 11:38:07 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-12 11:38:48 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 11:40:53 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/695991fb8e48cfabd7d269b1ff80a28f17c79806
Cr-Commit-Position: refs/heads/master@{#411596}

Powered by Google App Engine
This is Rietveld 408576698