Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3432)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunSignInProcessor.java

Issue 2237293003: [FRE] Change the First Run Experience launching behavior (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunFlowSequencer.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunSignInProcessor.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunSignInProcessor.java b/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunSignInProcessor.java
index e1223f560c68cbc8c9f3e9e4f1e02b7c75bceab7..0570a90ed316d2938e9368379a24421f7469798a 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunSignInProcessor.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunSignInProcessor.java
@@ -68,16 +68,13 @@ public final class FirstRunSignInProcessor {
return;
}
- // Skip sign in if Chrome is neither started via Chrome icon nor GSA (Google Search App).
- if (!TextUtils.equals(activity.getIntent().getAction(), Intent.ACTION_MAIN)
- && IntentHandler.determineExternalIntentSource(
- activity.getPackageName(), activity.getIntent())
- != ExternalAppId.GSA) {
- return;
- }
-
- // Otherwise, force trigger the FRE.
- if (!firstRunFlowComplete) {
+ // Otherwise, force trigger the FRE if Chrome is started via Chrome icon or via intent from
+ // GSA.
+ if (!firstRunFlowComplete
+ && (TextUtils.equals(activity.getIntent().getAction(), Intent.ACTION_MAIN)
+ || IntentHandler.determineExternalIntentSource(
+ activity.getPackageName(), activity.getIntent())
+ == ExternalAppId.GSA)) {
requestToFireIntentAndFinish(activity);
return;
}
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunFlowSequencer.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698