chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnectionService.java - Issue 2237293003: [FRE] Change the First Run Experience launching behavior

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnectionService.java

Issue 2237293003: [FRE] Change the First Run Experience launching behavior (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnectionService.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnectionService.java b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnectionService.java

index d49818ccf1cd4856ae98c9fa2bf0fa005cfe8be8..538de539f1a9a95fb486fc9df211a16df3e557d5 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnectionService.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnectionService.java

@@ -11,6 +11,8 @@ import android.os.IBinder;

import android.support.customtabs.CustomTabsService;

import android.support.customtabs.CustomTabsSessionToken;

+import org.chromium.chrome.browser.IntentHandler;

+import org.chromium.chrome.browser.IntentHandler.ExternalAppId;

import org.chromium.chrome.browser.firstrun.FirstRunFlowSequencer;

import java.util.List;

@@ -74,8 +76,13 @@ public class CustomTabsConnectionService extends CustomTabsService {

private boolean isFirstRunDone() {

if (mBindIntent == null) return true;

- boolean firstRunNecessary = FirstRunFlowSequencer

- .checkIfFirstRunIsNecessary(getApplicationContext(), mBindIntent) != null;

+ boolean showLightweightFre =

+ IntentHandler.determineExternalIntentSource(this.getPackageName(), mBindIntent)

+ != ExternalAppId.GSA;

+ boolean firstRunNecessary =

+ FirstRunFlowSequencer.checkIfFirstRunIsNecessary(

+ getApplicationContext(), mBindIntent, showLightweightFre)

+ != null;

if (!firstRunNecessary) {

mBindIntent = null;

return true;