[FRE] Change the First Run Experience launching behavior

chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunFlowSequencer.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.firstrun;
 
 import android.accounts.Account;
 import android.app.Activity;
 import android.content.Context;
 import android.content.Intent;
 import android.os.Bundle;
-import android.text.TextUtils;
 
 import org.chromium.base.ApiCompatibilityUtils;
 import org.chromium.base.CommandLine;
 import org.chromium.base.FieldTrialList;
 import org.chromium.base.VisibleForTesting;
 import org.chromium.chrome.browser.ChromeSwitches;
-import org.chromium.chrome.browser.IntentHandler;
-import org.chromium.chrome.browser.IntentHandler.ExternalAppId;
 import org.chromium.chrome.browser.net.spdyproxy.DataReductionProxySettings;
 import org.chromium.chrome.browser.preferences.PrefServiceBridge;
 import org.chromium.chrome.browser.preferences.privacy.PrivacyPreferencesManager;
 import org.chromium.chrome.browser.services.AndroidEduAndChildAccountHelper;
 import org.chromium.chrome.browser.signin.SigninManager;
 import org.chromium.chrome.browser.util.FeatureUtilities;
 import org.chromium.components.sync.signin.AccountManagerHelper;
 import org.chromium.components.sync.signin.ChromeSigninController;
 
 /**
@@ skipping 183 matching lines @@
         }
 
         // Mark the FRE flow as complete and set the sign-in flow preferences if necessary.
         FirstRunSignInProcessor.finalizeFirstRunFlowState(activity, data);
     }
 
     /**
      * Checks if the First Run needs to be launched.
      * @return The intent to launch the First Run Experience if necessary, or null.
      * @param context The context.
-     * @param fromIntent The intent that was used to launch Chrome. It contains the information of
-     * the client to launch different types of the First Run Experience.
+     * @param fromChromeIcon Whether Chrome is opened via the Chrome icon.
+     * @param forLightweightFre Whether this is a check for the Lightweight First Run Experience.
      */
-    public static Intent checkIfFirstRunIsNecessary(Context context, Intent fromIntent) {
+    public static Intent checkIfFirstRunIsNecessary(
+            Context context, boolean fromChromeIcon, boolean forLightweightFre) {
         // If FRE is disabled (e.g. in tests), proceed directly to the intent handling.
         if (CommandLine.getInstance().hasSwitch(ChromeSwitches.DISABLE_FIRST_RUN_EXPERIENCE)
                 || ApiCompatibilityUtils.isDemoUser(context)) {
             return null;
         }
 
         // If Chrome isn't opened via the Chrome icon, and the user accepted the ToS
         // in the Setup Wizard, skip any First Run Experience screens and proceed directly
         // to the intent handling.
-        final boolean fromChromeIcon =

[Bernhard Bauer, 2016/08/16 23:20:08]

Is there a reason you're moving this out to the call sites?

[gogerald1, 2016/08/17 14:44:10]

Done. just made the parameter a little specific, may be keep the original
parameter better here to avoid duplication,

-                fromIntent != null && TextUtils.equals(fromIntent.getAction(), Intent.ACTION_MAIN);
         if (!fromChromeIcon && ToSAckedReceiver.checkAnyUserHasSeenToS(context)) return null;
 
         final boolean baseFreComplete = FirstRunStatus.getFirstRunFlowComplete(context);
         if (!baseFreComplete) {
-            // Show full First Run Experience if Chrome is opened via Chrome icon or GSA (Google
-            // Search App).
-            if (fromChromeIcon
-                    || (fromIntent != null
-                        && IntentHandler.determineExternalIntentSource(
-                            context.getPackageName(), fromIntent) == ExternalAppId.GSA)) {
+            if (!forLightweightFre) {

[Bernhard Bauer, 2016/08/16 23:20:08]

Invert the check to put the positive branch first?

[gogerald1, 2016/08/17 14:44:11]

Done.

                 return createGenericFirstRunIntent(context, fromChromeIcon);
-            }
-
-            // Show lightweight First Run Experience if the user has not accepted the ToS.
-            if (!FirstRunStatus.shouldSkipWelcomePage(context)
-                    && !FirstRunStatus.getLightweightFirstRunFlowComplete(context)) {
-                return createLightweightFirstRunIntent(context, fromChromeIcon);
+            } else {
+                if (!FirstRunStatus.shouldSkipWelcomePage(context)
+                        && !FirstRunStatus.getLightweightFirstRunFlowComplete(context)) {
+                    return createLightweightFirstRunIntent(context, fromChromeIcon);
+                }
             }
         }
 
         // Promo pages are removed, so there is nothing else to show in FRE.
         return null;
     }
 
     private static Intent createLightweightFirstRunIntent(Context context, boolean fromChromeIcon) {
         Intent intent = new Intent();
         intent.setClassName(context, LightweightFirstRunActivity.class.getName());
         intent.putExtra(FirstRunActivity.COMING_FROM_CHROME_ICON, fromChromeIcon);
         intent.putExtra(FirstRunActivity.START_LIGHTWEIGHT_FRE, true);
         return intent;
     }
 
     /**
      * @return A generic intent to show the First Run Activity.
      * @param context The context
      * @param fromChromeIcon Whether Chrome is opened via the Chrome icon
     */
     public static Intent createGenericFirstRunIntent(Context context, boolean fromChromeIcon) {
         Intent intent = new Intent();
         intent.setClassName(context, FirstRunActivity.class.getName());
         intent.putExtra(FirstRunActivity.COMING_FROM_CHROME_ICON, fromChromeIcon);
         intent.putExtra(FirstRunActivity.USE_FRE_FLOW_SEQUENCER, true);
         return intent;
     }
 }