Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 223723002: fixing epsilion value (Closed)

Created:
6 years, 8 months ago by MuVen
Modified:
6 years, 8 months ago
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

BUG=359530 We are showing unnecessary glow effect during the max scroll. As updated in the bug (https://code.google.com/p/chromium/issues/detail?id=359530) unused_root_delta most of the time it is 0.01 or 0.02 becuase of which glow effect is shown. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261699

Patch Set 1 #

Patch Set 2 : changes done based on review comments, added test case #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -6 lines) Patch
M cc/trees/layer_tree_host_impl.cc View 1 1 chunk +5 lines, -6 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
MuVen
Please take a look at the issue and let me know how to take on ...
6 years, 8 months ago (2014-04-03 10:59:29 UTC) #1
MuVen
I wasnt sure is this a regression of some other changes or not , After ...
6 years, 8 months ago (2014-04-03 11:47:19 UTC) #2
aelias_OOO_until_Jul13
OK. Looks like the error can actually go that high and I have no better ...
6 years, 8 months ago (2014-04-03 18:14:54 UTC) #3
MuVen
Hi Aelias, Please take a look on the changes, Uploaded patch as per review comments. ...
6 years, 8 months ago (2014-04-04 05:16:00 UTC) #4
aelias_OOO_until_Jul13
lgtm
6 years, 8 months ago (2014-04-04 05:21:06 UTC) #5
MuVen
The CQ bit was checked by sataya.m@samsung.com
6 years, 8 months ago (2014-04-04 05:28:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sataya.m@samsung.com/223723002/20001
6 years, 8 months ago (2014-04-04 05:28:19 UTC) #7
commit-bot: I haz the power
6 years, 8 months ago (2014-04-04 07:45:57 UTC) #8
Message was sent while issue was closed.
Change committed as 261699

Powered by Google App Engine
This is Rietveld 408576698