Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2237223004: Add/fix some comments for BlimpDelegatingOutputSurface (Closed)

Created:
4 years, 4 months ago by danakj
Modified:
4 years, 4 months ago
Reviewers:
nyquist, Wez, enne (OOO)
CC:
anandc+watch-blimp_chromium.org, cc-bugs_chromium.org, chromium-reviews, dtrainor+watch-blimp_chromium.org, gcasto+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, nyquist, piman, shaktisahu+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add/fix some comments for BlimpDelegatingOutputSurface (and for its origin class TestDelegatingOutputSurface). R=enne, wez BUG=606056 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/63bba35428fa2c43e8790bc1dce619dee81df7ef Cr-Commit-Position: refs/heads/master@{#411863}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M blimp/client/feature/compositor/blimp_delegating_output_surface.h View 2 chunks +3 lines, -2 lines 0 comments Download
M cc/test/test_delegating_output_surface.h View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
danakj
4 years, 4 months ago (2016-08-12 18:22:07 UTC) #3
enne (OOO)
lgtm
4 years, 4 months ago (2016-08-12 18:32:52 UTC) #5
nyquist
lgtm if you want to land it. Feel free to wait for wez@ as well, ...
4 years, 4 months ago (2016-08-12 23:42:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2237223004/1
4 years, 4 months ago (2016-08-13 02:36:13 UTC) #11
danakj
On 2016/08/12 23:42:39, nyquist wrote: > lgtm if you want to land it. Feel free ...
4 years, 4 months ago (2016-08-13 02:36:17 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-13 02:39:35 UTC) #13
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/63bba35428fa2c43e8790bc1dce619dee81df7ef Cr-Commit-Position: refs/heads/master@{#411863}
4 years, 4 months ago (2016-08-13 02:41:41 UTC) #15
Wez
4 years, 4 months ago (2016-08-18 23:07:30 UTC) #16
Message was sent while issue was closed.
blimp/ LGTM (belatedly ;)

Thanks for the comment cleanup :)

Powered by Google App Engine
This is Rietveld 408576698