Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 2237223002: pathops coincident work (Closed)

Created:
4 years, 4 months ago by caryclark
Modified:
4 years, 3 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

pathops coincident work This is working towards fixing all bugs around simplifying the tiger. This installment simplifies the point-t intersection list as it is built rather than doing the analysis once the intersections are complete. This avoids getting the list in an inconsistent state and makes coincident checks faster and more stable. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2237223002 TBR=reed@google.com BUG=skia:5131 Committed: https://skia.googlesource.com/skia/+/30b9fdd6a1d607bde20c793af65b5e2e8a1737ca

Patch Set 1 #

Patch Set 2 : wip; detect, correct spans out of order #

Patch Set 3 : wip; overlapping / out of order t values #

Patch Set 4 : wip; merge more #

Patch Set 5 : wip; merge detach #

Patch Set 6 : wio; further #

Patch Set 7 : wip; remove aborted abort strategy #

Patch Set 8 : wip; regressed a bit, need to debug new code more #

Patch Set 9 : include first member in check for merge #

Patch Set 10 : wip; merge matches #

Patch Set 11 : wip; continuing to refactor span-base merge #

Patch Set 12 : merge with tot #

Patch Set 13 : remove change to conicpaths #

Patch Set 14 : fix merge #

Patch Set 15 : wip; getting my head around eliminating trivial spans #

Patch Set 16 : wip; still working on merge #

Patch Set 17 : simplify change #

Patch Set 18 : wip; checkpoint; old tests work #

Patch Set 19 : coincident edges not detected? #

Patch Set 20 : up to 10 bits working on tiger #

Patch Set 21 : all std tests work, tiger up to 12 #

Patch Set 22 : remove unused code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2633 lines, -1005 lines) Patch
M src/pathops/SkAddIntersections.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +12 lines, -9 lines 0 comments Download
M src/pathops/SkOpAngle.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +1 line, -1 line 0 comments Download
M src/pathops/SkOpAngle.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +3 lines, -1 line 0 comments Download
M src/pathops/SkOpCoincidence.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 5 chunks +8 lines, -4 lines 0 comments Download
M src/pathops/SkOpCoincidence.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 10 chunks +58 lines, -26 lines 0 comments Download
M src/pathops/SkOpContour.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +1 line, -1 line 0 comments Download
M src/pathops/SkOpSegment.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 3 chunks +5 lines, -2 lines 0 comments Download
M src/pathops/SkOpSegment.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 5 chunks +16 lines, -10 lines 0 comments Download
M src/pathops/SkOpSpan.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 12 chunks +24 lines, -14 lines 0 comments Download
M src/pathops/SkOpSpan.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 8 chunks +119 lines, -42 lines 0 comments Download
M src/pathops/SkPathOpsCommon.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 2 chunks +1 line, -2 lines 0 comments Download
M src/pathops/SkPathOpsDebug.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 2 chunks +2 lines, -2 lines 0 comments Download
M src/pathops/SkPathOpsDebug.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 25 chunks +183 lines, -85 lines 0 comments Download
M src/pathops/SkPathOpsPoint.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 2 chunks +29 lines, -0 lines 0 comments Download
M src/pathops/SkPathOpsTypes.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 3 chunks +9 lines, -7 lines 0 comments Download
M tests/PathOpsDebug.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 6 chunks +6 lines, -6 lines 0 comments Download
M tests/PathOpsExtendedTest.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +3 lines, -11 lines 0 comments Download
M tests/PathOpsExtendedTest.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 3 chunks +5 lines, -23 lines 0 comments Download
M tests/PathOpsOpTest.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 50 chunks +63 lines, -51 lines 0 comments Download
M tests/PathOpsSimplifyFailTest.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +1 line, -1 line 0 comments Download
M tests/PathOpsSimplifyTest.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +1 line, -1 line 0 comments Download
M tools/pathops_sorter.htm View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 2 chunks +6 lines, -12 lines 0 comments Download
M tools/pathops_visualizer.htm View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +2077 lines, -694 lines 0 comments Download

Messages

Total messages: 7 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2237223002/420001
4 years, 3 months ago (2016-08-31 20:56:51 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 21:36:34 UTC) #7
Message was sent while issue was closed.
Committed patchset #22 (id:420001) as
https://skia.googlesource.com/skia/+/30b9fdd6a1d607bde20c793af65b5e2e8a1737ca

Powered by Google App Engine
This is Rietveld 408576698